| Message ID | 20200819153539.32698-1-ed.czeck@atomicrules.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ferruh Yigit |
| Headers | show |
| Series | net/ark: fix meson build | expand |
| Context | Check | Description |
|---|---|---|
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-intel-Performance | success | Performance Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/iol-testing | success | Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
| ci/checkpatch | success | coding style OK |
On 8/19/2020 4:35 PM, Ed Czeck wrote: > * Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match > the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. > * Install header file needed for dynamic library. > > Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com> > --- > drivers/net/ark/meson.build | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build > index 99151bba1..6840bc622 100644 > --- a/drivers/net/ark/meson.build > +++ b/drivers/net/ark/meson.build > @@ -11,3 +11,6 @@ sources = files('ark_ddm.c', > 'ark_pktgen.c', > 'ark_rqp.c', > 'ark_udm.c') > + > +install_headers('ark_ext.h') > +cflags += '-DRTE_LIBRTE_ARK_PAD_TX' > Hi Ed, Why not remove the 'RTE_LIBRTE_ARK_PAD_TX' completely, this is a good opportunity for it. In meson it is not really a config option as it is. This can be default option or can be converted into runtime config. For runtime config it can be a devarg, but since it is in Tx data path, if you don't want additional condition perhaps defining this as an alternative Tx burst function can work.
diff --git a/drivers/net/ark/meson.build b/drivers/net/ark/meson.build index 99151bba1..6840bc622 100644 --- a/drivers/net/ark/meson.build +++ b/drivers/net/ark/meson.build @@ -11,3 +11,6 @@ sources = files('ark_ddm.c', 'ark_pktgen.c', 'ark_rqp.c', 'ark_udm.c') + +install_headers('ark_ext.h') +cflags += '-DRTE_LIBRTE_ARK_PAD_TX'
* Set RTE_LIBRTE_ARK_PAD_TX in local meson.build to match the CONFIG_RTE_LIBRTE_ARK_PAD_TX setting used in make. * Install header file needed for dynamic library. Signed-off-by: Ed Czeck <ed.czeck@atomicrules.com> --- drivers/net/ark/meson.build | 3 +++ 1 file changed, 3 insertions(+)