From patchwork Wed Aug 12 16:37:29 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Artur Rojek X-Patchwork-Id: 75623 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 815D3A034C; Tue, 18 Aug 2020 15:42:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B5EDE2BE2; Tue, 18 Aug 2020 15:42:50 +0200 (CEST) Received: from mail-lj1-f194.google.com (mail-lj1-f194.google.com [209.85.208.194]) by dpdk.org (Postfix) with ESMTP id 972101C01F for ; Wed, 12 Aug 2020 18:37:57 +0200 (CEST) Received: by mail-lj1-f194.google.com with SMTP id t6so2947188ljk.9 for ; Wed, 12 Aug 2020 09:37:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YkNDZXlkWnaR0FEosPWD5aDGcPtUYCWT9XqNWUE24JI=; b=gUAerS/W20oCgWuuw8JtTMarnLYJDrZsxvyQt42C4DIRS83uDPphqozTnuYU5V45H3 RQbhJ53xbVoJg02EiFiGb2ktIEuysAY1iygvnG5ljMGQJWf8GQoUG0oqCnWwkFcnAbpP UZZrPZddmTZYS4FQOEo5KB3Eiaex/kl8uegygSHHvGAf44w9zkZMIsTswUz+gN2mhvny YsJWQyk2fhkDO562hCdaVzMOTQldNR2F/IIkw2to/l20Zz3CPBfgzRvrpCKfKachtgL7 lnfgp6wdEocD95DugUFcISiCeIHlUkwEYFt5/uI/CGpJrqG1jQYb/tjwNCV4/DebkYwx j5ag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=YkNDZXlkWnaR0FEosPWD5aDGcPtUYCWT9XqNWUE24JI=; b=BG1EEpR76zmFoGWwvumRduzRpmDwljSjPfASOHttnZjBxGYWNuJtB51g7F/bulq5Ib FH/uYjkmUQ6mDEnzpyCGfm89BDJ9xggT6XgOCtNWvvZAtAeLh+TV4eCX4mai6AS6lhry ffAcb4fBYx8VLXHMoXa5TmIc/jctcKPhqg+YgvhwPUIrJFnHCEBRaZ8gi6jB/F36Vcf9 QiqDrLyP843r8W4GDP0/GGBy9wiRBAOJ8EnerDu8UxA68K8nuYtxOxWsJyZK3iCpqugy xfawxN7EOFxHnDb3RxWiQV+cKm8rFwWSlXV8dGGu9XfsQghGW5+Ow+GOdDrD1nAo6ky4 OQSA== X-Gm-Message-State: AOAM530YxrOaxQSqrdIkV2wCBb1vEhEQl2N6hdbB/kTxDUuHuze4KUmr b+Bg1pArzn2hw9XszN6oKoVgzA== X-Google-Smtp-Source: ABdhPJyW+WStzzgdKhGlzitlHbr3QtdT5mQar+e2pV/yFlcOg/W71y39+RzQ4O4CBAFzsIbmxunmqQ== X-Received: by 2002:a2e:8997:: with SMTP id c23mr45406lji.150.1597250277107; Wed, 12 Aug 2020 09:37:57 -0700 (PDT) Received: from arojek.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id y13sm537088ljd.19.2020.08.12.09.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Aug 2020 09:37:56 -0700 (PDT) From: Artur Rojek To: Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Igor Chauskin Cc: dev@dpdk.org, stable@dpdk.org, Artur Rojek Date: Wed, 12 Aug 2020 18:37:29 +0200 Message-Id: <20200812163729.4933-1-ar@semihalf.com> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Mailman-Approved-At: Tue, 18 Aug 2020 15:42:49 +0200 Subject: [dpdk-dev] [PATCH] net/ena/base: fix doorbell evaluation for the LLQ case X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Michal Krawczyk This patch adds a missing LLQ-related check in the ena_com_is_doorbell_needed() routine, which is relevant for the feature supported by the next generation HW of the ENA. Fixes: b2b02edeb0d6 ("net/ena/base: upgrade HAL for new HW features") CC: stable@dpdk.org Signed-off-by: Michal Krawczyk [Extracted from a bigger patch] Signed-off-by: Artur Rojek --- drivers/net/ena/base/ena_eth_com.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ena/base/ena_eth_com.h b/drivers/net/ena/base/ena_eth_com.h index e37b642d4..3d66237b8 100644 --- a/drivers/net/ena/base/ena_eth_com.h +++ b/drivers/net/ena/base/ena_eth_com.h @@ -133,7 +133,8 @@ static inline bool ena_com_is_doorbell_needed(struct ena_com_io_sq *io_sq, llq_info = &io_sq->llq_info; num_descs = ena_tx_ctx->num_bufs; - if (unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx))) + if (llq_info->disable_meta_caching || + unlikely(ena_com_meta_desc_changed(io_sq, ena_tx_ctx))) ++num_descs; if (num_descs > llq_info->descs_num_before_header) {