diff mbox series

usertools: warn about future removal of setup script

Message ID 20200806171303.3989777-1-thomas@monjalon.net (mailing list archive)
State Accepted, archived
Headers show
Series usertools: warn about future removal of setup script | expand

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Thomas Monjalon Aug. 6, 2020, 5:13 p.m. UTC
As agreed in the deprecation notice, the "generic" script
to setup the Linux environment will be removed in DPDK 20.11.
Some specific parts may be converted into dedicated scripts.

In the meantime, a warning will be printed to users of this script.

Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
 usertools/dpdk-setup.sh | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Stephen Hemminger Aug. 6, 2020, 6:14 p.m. UTC | #1
On Thu,  6 Aug 2020 19:13:03 +0200
Thomas Monjalon <thomas@monjalon.net> wrote:

> As agreed in the deprecation notice, the "generic" script
> to setup the Linux environment will be removed in DPDK 20.11.
> Some specific parts may be converted into dedicated scripts.
> 
> In the meantime, a warning will be printed to users of this script.
> 
> Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  usertools/dpdk-setup.sh | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
> index e5bbe9feec..411bf2e07f 100755
> --- a/usertools/dpdk-setup.sh
> +++ b/usertools/dpdk-setup.sh
> @@ -592,6 +592,10 @@ while [ "$QUIT" == "0" ]; do
>  	echo "[$OPTION_NUM] Exit Script"
>  	OPTIONS[$OPTION_NUM]="quit"
>  	echo ""
> +	echo '--------------------------------------------------'
> +	echo 'WARNING: This tool will be removed from DPDK 20.11'
> +	echo '--------------------------------------------------'
> +	echo
>  	echo -n "Option: "
>  	read our_entry
>  	echo ""

Acked-by: Stephen Hemminger <stephen@networkplumber.org>
Thomas Monjalon Aug. 7, 2020, 11:40 a.m. UTC | #2
06/08/2020 20:14, Stephen Hemminger:
> On Thu,  6 Aug 2020 19:13:03 +0200
> Thomas Monjalon <thomas@monjalon.net> wrote:
> 
> > As agreed in the deprecation notice, the "generic" script
> > to setup the Linux environment will be removed in DPDK 20.11.
> > Some specific parts may be converted into dedicated scripts.
> > 
> > In the meantime, a warning will be printed to users of this script.
> > 
> > Suggested-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> > ---
> > --- a/usertools/dpdk-setup.sh
> > +++ b/usertools/dpdk-setup.sh
> > @@ -592,6 +592,10 @@ while [ "$QUIT" == "0" ]; do
> >  	echo "[$OPTION_NUM] Exit Script"
> >  	OPTIONS[$OPTION_NUM]="quit"
> >  	echo ""
> > +	echo '--------------------------------------------------'
> > +	echo 'WARNING: This tool will be removed from DPDK 20.11'
> > +	echo '--------------------------------------------------'
> > +	echo
> >  	echo -n "Option: "
> >  	read our_entry
> >  	echo ""
> 
> Acked-by: Stephen Hemminger <stephen@networkplumber.org>

Applied
diff mbox series

Patch

diff --git a/usertools/dpdk-setup.sh b/usertools/dpdk-setup.sh
index e5bbe9feec..411bf2e07f 100755
--- a/usertools/dpdk-setup.sh
+++ b/usertools/dpdk-setup.sh
@@ -592,6 +592,10 @@  while [ "$QUIT" == "0" ]; do
 	echo "[$OPTION_NUM] Exit Script"
 	OPTIONS[$OPTION_NUM]="quit"
 	echo ""
+	echo '--------------------------------------------------'
+	echo 'WARNING: This tool will be removed from DPDK 20.11'
+	echo '--------------------------------------------------'
+	echo
 	echo -n "Option: "
 	read our_entry
 	echo ""