diff mbox series

[2/4] test/stack: launch tests with mp remote launch API

Message ID 20200805155721.19808-3-steven.lariau@arm.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers show
Series test/stack: improve multithreaded test | expand

Checks

Context Check Description
ci/checkpatch warning coding style issues

Commit Message

Steven Lariau Aug. 5, 2020, 3:57 p.m. UTC
All the cores use the same argument object, so there is no need to use
a loop to launch the test on every core one by one.
Replace loop with one call to rte_eal_mp_remote_launch


Signed-off-by: Steven Lariau <steven.lariau@arm.com>
Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
Reviewed-by: Phil Yang <phil.yang@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
 app/test/test_stack.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

Comments

Eads, Gage Aug. 11, 2020, 8:13 p.m. UTC | #1
> -----Original Message-----
> From: Steven Lariau <steven.lariau@arm.com>
> Sent: Wednesday, August 5, 2020 10:57 AM
> To: Eads, Gage <gage.eads@intel.com>; Olivier Matz
> <olivier.matz@6wind.com>
> Cc: dev@dpdk.org; honnappa.nagarahalli@arm.com;
> dharmik.thakkar@arm.com; nd@arm.com; Steven Lariau
> <steven.lariau@arm.com>
> Subject: [PATCH 2/4] test/stack: launch tests with mp remote launch API
> 
> All the cores use the same argument object, so there is no need to use
> a loop to launch the test on every core one by one.
> Replace loop with one call to rte_eal_mp_remote_launch
> 
> 
> Signed-off-by: Steven Lariau <steven.lariau@arm.com>
> Reviewed-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>

Acked-by: Gage Eads <gage.eads@intel.com>

Thanks,
Gage
diff mbox series

Patch

diff --git a/app/test/test_stack.c b/app/test/test_stack.c
index 5a7273a7d..c100d9faf 100644
--- a/app/test/test_stack.c
+++ b/app/test/test_stack.c
@@ -322,7 +322,6 @@  static int
 test_stack_multithreaded(uint32_t flags)
 {
 	struct test_args args;
-	unsigned int lcore_id;
 	struct rte_stack *s;
 	rte_atomic64_t size;
 
@@ -345,14 +344,8 @@  test_stack_multithreaded(uint32_t flags)
 	args.s = s;
 	args.sz = &size;
 
-	RTE_LCORE_FOREACH_SLAVE(lcore_id) {
-		if (rte_eal_remote_launch(stack_thread_push_pop,
-					  &args, lcore_id))
-			rte_panic("Failed to launch lcore %d\n", lcore_id);
-	}
-
-	stack_thread_push_pop(&args);
-
+	if (rte_eal_mp_remote_launch(stack_thread_push_pop, &args, CALL_MASTER))
+		rte_panic("Failed to launch tests\n");
 	rte_eal_mp_wait_lcore();
 
 	rte_stack_free(s);