[v2,20.08,5/6] rte_ethdev: change comment to rte_dev_eth_mac_addr_add

Message ID 20200730005804.19251-6-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series inclusive language fixes and deprecation notices |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK

Commit Message

Stephen Hemminger July 30, 2020, 12:58 a.m. UTC
  The comment used the term whitelist and was awkardly written.
Replace it with simpler direct description of adding a new address.
No code or API changes for this.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
Acked-by: Luca Boccassi <bluca@debian.org>
---
 lib/librte_ethdev/rte_ethdev.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
  

Comments

Thomas Monjalon Aug. 6, 2020, 4:53 p.m. UTC | #1
30/07/2020 02:58, Stephen Hemminger:
> The comment used the term whitelist and was awkardly written.
> Replace it with simpler direct description of adding a new address.
> No code or API changes for this.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Luca Boccassi <bluca@debian.org>
> ---
>  lib/librte_ethdev/rte_ethdev.h | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
> index 57e4a6ca58fd..cde6a9645360 100644
> --- a/lib/librte_ethdev/rte_ethdev.h
> +++ b/lib/librte_ethdev/rte_ethdev.h
> @@ -3387,8 +3387,7 @@ int rte_eth_dev_priority_flow_ctrl_set(uint16_t port_id,
>  				struct rte_eth_pfc_conf *pfc_conf);
>  
>  /**
> - * Add a MAC address to an internal array of addresses used to enable whitelist
> - * filtering to accept packets only if the destination MAC address matches.
> + * Add a MAC address to an set of addresses used for accepting incoming packets.

I propose this wording:

Add a MAC address to a set used for filtering incoming packets.
  

Patch

diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h
index 57e4a6ca58fd..cde6a9645360 100644
--- a/lib/librte_ethdev/rte_ethdev.h
+++ b/lib/librte_ethdev/rte_ethdev.h
@@ -3387,8 +3387,7 @@  int rte_eth_dev_priority_flow_ctrl_set(uint16_t port_id,
 				struct rte_eth_pfc_conf *pfc_conf);
 
 /**
- * Add a MAC address to an internal array of addresses used to enable whitelist
- * filtering to accept packets only if the destination MAC address matches.
+ * Add a MAC address to an set of addresses used for accepting incoming packets.
  *
  * @param port_id
  *   The port identifier of the Ethernet device.