diff mbox series

[v2,5/8] net/i40e/base: fix possible uninitialized variable

Message ID	20200727053451.22214-6-guinanx.sun@intel.com (mailing list archive)
State	Accepted, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: dGhgAzco0ZWE7DfGDGfpEJTUZOaxUwdT5iOsnr2GGEfYuFEC1wdYutuQn93Yn0a01qhJwGv3Mp AAc+Mkc4UovA== IronPort-SDR: e8q+EPXKsk/evg6pwzy3FLvj3rAd0Xd50tUxIGyA0sbOgQFtwU3xyv+fawBXFTO8ALxL4UlcmJ hUIQ6KUh+mbw== From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Beilei Xing <beilei.xing@intel.com>, Jeff Guo <jia.guo@intel.com>, Guinan Sun <guinanx.sun@intel.com>, stable@dpdk.org, Adam Ludkiewicz <adam.ludkiewicz@intel.com> Date: Mon, 27 Jul 2020 05:34:48 +0000 Message-Id: <20200727053451.22214-6-guinanx.sun@intel.com> In-Reply-To: <20200727053451.22214-1-guinanx.sun@intel.com> References: <20200721074000.30449-1-guinanx.sun@intel.com> <20200727053451.22214-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 5/8] net/i40e/base: fix possible uninitialized variable Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update i40e base code \| [v2,0/8] update i40e base code [v2,1/8] net/i40e/base: enable FEC on/off flag setting for X722 [v2,2/8] net/i40e/base: add PTYPE definition [v2,3/8] net/i40e/base: add new custom cloud filter types [v2,4/8] net/i40e/base: update FW API version to 1.11 [v2,5/8] net/i40e/base: fix possible uninitialized variable [v2,6/8] net/i40e/base: support unused ports disabling [v2,7/8] net/i40e/base: replace AQ command for NVM update [v2,8/8] net/i40e/base: update version

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Guinan Sun July 27, 2020, 5:34 a.m. UTC

  Fix possible uninitialized variable in i40e in the i40e_get_lpi_counters
function.

Fixes: 429bdc0cd967 ("net/i40e/base: add function to read LPI counters")
Cc: stable@dpdk.org

Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
V2:
* Modify commit message.
---
 drivers/net/i40e/base/i40e_common.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Guo, Jia July 27, 2020, 6:45 a.m. UTC | #1

Acked-by: Jeff Guo<jia.guo@intel.com>

On 7/27/2020 1:34 PM, Guinan Sun wrote:
> Fix possible uninitialized variable in i40e in the i40e_get_lpi_counters
> function.
>
> Fixes: 429bdc0cd967 ("net/i40e/base: add function to read LPI counters")
> Cc: stable@dpdk.org
>
> Signed-off-by: Adam Ludkiewicz <adam.ludkiewicz@intel.com>
> Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
> ---
> V2:
> * Modify commit message.
> ---
>   drivers/net/i40e/base/i40e_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
> index 46a0b7881..85c22849e 100644
> --- a/drivers/net/i40e/base/i40e_common.c
> +++ b/drivers/net/i40e/base/i40e_common.c
> @@ -7097,7 +7097,7 @@ enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,
>   				I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
>   				&cmd_status, tx_counter, rx_counter, NULL);
>   
> -		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
> +		if (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
>   			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
>   
>   		return retval;

diff mbox series

Patch

diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
index 46a0b7881..85c22849e 100644
--- a/drivers/net/i40e/base/i40e_common.c
+++ b/drivers/net/i40e/base/i40e_common.c
@@ -7097,7 +7097,7 @@  enum i40e_status_code i40e_get_lpi_counters(struct i40e_hw *hw,
 				I40E_AQ_RUN_PHY_ACT_DNL_OPCODE_GET_EEE_STAT,
 				&cmd_status, tx_counter, rx_counter, NULL);
 
-		if (cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
+		if (!retval && cmd_status != I40E_AQ_RUN_PHY_ACT_CMD_STAT_SUCC)
 			retval = I40E_ERR_ADMIN_QUEUE_ERROR;
 
 		return retval;