diff mbox series

[v1,2/2] app/crypto-perf: enable security feature for security tests

Message ID 20200716152952.65107-3-david.coyle@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series enable security feature for security tests |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/travis-robot success Travis build: passed

Commit Message

Coyle, David July 16, 2020, 3:29 p.m. UTC 
The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the
ff_disable device configuration option for all crypto performance tests,
including security related tests. This patch updates the crypto
performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and
PDCP security tests.

Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")

Signed-off-by: David Coyle <david.coyle@intel.com>
---
 app/test-crypto-perf/main.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

Comments

Akhil Goyal July 16, 2020, 5:01 p.m. UTC | #1 
> 
> The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the
> ff_disable device configuration option for all crypto performance tests,
> including security related tests. This patch updates the crypto
> performance tool to not disable RTE_CRYPTODEV_FF_SECURITY for DOCSIS and
> PDCP security tests.
> 
> Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")
> 
> Signed-off-by: David Coyle <david.coyle@intel.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
De Lara Guarch, Pablo July 17, 2020, 6:19 p.m. UTC | #2 
> -----Original Message-----
> From: Coyle, David <david.coyle@intel.com>
> Sent: Thursday, July 16, 2020 4:30 PM
> To: akhil.goyal@nxp.com; Doherty, Declan <declan.doherty@intel.com>; De
> Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Trahe, Fiona
> <fiona.trahe@intel.com>
> Cc: dev@dpdk.org; Ryan, Brendan <brendan.ryan@intel.com>; O'loingsigh,
> Mairtin <mairtin.oloingsigh@intel.com>; Coyle, David <david.coyle@intel.com>
> Subject: [PATCH v1 2/2] app/crypto-perf: enable security feature for security
> tests
> 
> The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the ff_disable
> device configuration option for all crypto performance tests, including security
> related tests. This patch updates the crypto performance tool to not disable
> RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.
> 
> Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")
> 
> Signed-off-by: David Coyle <david.coyle@intel.com>

Same comment as on the first patch of this set, but with commit 8fd2b5a60d1 ("app/crypto-perf: support PDCP")

Thanks,
Pablo
Akhil Goyal July 18, 2020, 8:08 p.m. UTC | #3 
> > The RTE_CRYPTODEV_FF_SECURITY feature was disabled through the
> ff_disable
> > device configuration option for all crypto performance tests, including security
> > related tests. This patch updates the crypto performance tool to not disable
> > RTE_CRYPTODEV_FF_SECURITY for DOCSIS and PDCP security tests.
> >
> > Fixes: d4a131a9498d ("test/crypto-perf: support DOCSIS protocol")
> >
> > Signed-off-by: David Coyle <david.coyle@intel.com>
> 
> Same comment as on the first patch of this set, but with commit 8fd2b5a60d1
> ("app/crypto-perf: support PDCP")
> 
No need to backport this as well as explained in the 1st patch.
diff mbox series

Patch

diff --git a/app/test-crypto-perf/main.c b/app/test-crypto-perf/main.c
index edeea9c1b..8f8e580e4 100644
--- a/app/test-crypto-perf/main.c
+++ b/app/test-crypto-perf/main.c
@@ -203,10 +203,13 @@  cperf_initialize_cryptodev(struct cperf_options *opts, uint8_t *enabled_cdevs)
 		struct rte_cryptodev_config conf = {
 			.nb_queue_pairs = opts->nb_qps,
 			.socket_id = socket_id,
-			.ff_disable = RTE_CRYPTODEV_FF_SECURITY |
-				      RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO,
+			.ff_disable = RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO,
 		};
 
+		if (opts->op_type != CPERF_PDCP &&
+				opts->op_type != CPERF_DOCSIS)
+			conf.ff_disable |= RTE_CRYPTODEV_FF_SECURITY;
+
 		struct rte_cryptodev_qp_conf qp_conf = {
 			.nb_descriptors = opts->nb_descriptors
 		};