[v3,14/19] net/ixgbe/base: improve log about autonego being disabled

Message ID 20200709080046.65879-15-guinanx.sun@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Series update ixgbe base code |


Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Guinan Sun July 9, 2020, 8 a.m. UTC
  On ESXi OS, when user disables auto negotiation, the following log
appears: "(unsupported) Flow control autoneg is disabled".
It is true that auto negotiation is disabled but it is
not necessarily true that it is not supported.

Signed-off-by: Jakub Chylkowski <jakubx.chylkowski@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
Reviewed-by: Wei Zhao <wei.zhao1@intel.com>
 drivers/net/ixgbe/base/ixgbe_common.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)


diff --git a/drivers/net/ixgbe/base/ixgbe_common.c b/drivers/net/ixgbe/base/ixgbe_common.c
index 927877b6a..ca8ec907e 100644
--- a/drivers/net/ixgbe/base/ixgbe_common.c
+++ b/drivers/net/ixgbe/base/ixgbe_common.c
@@ -3076,8 +3076,9 @@  void ixgbe_fc_autoneg(struct ixgbe_hw *hw)
 	 * - link is not up.
 	if (hw->fc.disable_fc_autoneg) {
-			     "Flow control autoneg is disabled");
+		/* TODO: This should be just an informative log */
+			      "Flow control autoneg is disabled");
 		goto out;