diff mbox series

net/i40e: fix getting eeprom information

Message ID 20200702123717.2251897-1-pivashchenko@nfware.com (mailing list archive)
State Accepted, archived
Delegated to: Qi Zhang
Headers
Series net/i40e: fix getting eeprom information |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS

Commit Message

Pavel Ivashchenko July 2, 2020, 12:37 p.m. UTC 
Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Igor Ryzhov July 5, 2020, 1:24 p.m. UTC | #1 
CCing i40e maintainers.
This is a trivial fix without which getting module EEPROM doesn't work at
all.

On Thu, Jul 2, 2020 at 3:37 PM Pavel Ivashchenko <pivashchenko@nfware.com>
wrote:

> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/i40e/i40e_ethdev.c
> b/drivers/net/i40e/i40e_ethdev.c
> index 970a31cb2..5fdfadf7b 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -12093,7 +12093,7 @@ static int i40e_get_module_eeprom(struct
> rte_eth_dev *dev,
>                 }
>                 status = i40e_aq_get_phy_register(hw,
>                                 I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
> -                               addr, offset, 1, &value, NULL);
> +                               addr, 1, offset, &value, NULL);
>                 if (status)
>                         return -EIO;
>                 data[i] = (uint8_t)value;
> --
> 2.25.1
>
>
Qi Zhang July 7, 2020, 2:18 a.m. UTC | #2 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Pavel Ivashchenko
> Sent: Thursday, July 2, 2020 8:37 PM
> To: dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/i40e: fix getting eeprom information
> 
> Signed-off-by: Pavel Ivashchenko <pivashchenko@nfware.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi
diff mbox series

Patch

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 970a31cb2..5fdfadf7b 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -12093,7 +12093,7 @@  static int i40e_get_module_eeprom(struct rte_eth_dev *dev,
 		}
 		status = i40e_aq_get_phy_register(hw,
 				I40E_AQ_PHY_REG_ACCESS_EXTERNAL_MODULE,
-				addr, offset, 1, &value, NULL);
+				addr, 1, offset, &value, NULL);
 		if (status)
 			return -EIO;
 		data[i] = (uint8_t)value;