diff mbox series

[v3,2/7] build: remove unnecessary variable

Message ID 20200630141433.818517-3-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series improve DPDK static builds with meson | expand


Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Bruce Richardson June 30, 2020, 2:14 p.m. UTC
Since all libraries are explicitly linked as part of a build, we no longer
need to track ones that should be always included for linking against apps.

Previously telemetry was special-cased for linking as it was not directly
needed by the linker when linking the apps, since they never called into it
directly. This meant that it could be forgotten when specifying the app
dependencies, and so the telemetry support would not work. This
special-casing was never needed for make as it always linked in all
libraries, as meson does now.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
 app/meson.build | 2 +-
 meson.build     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)
diff mbox series


diff --git a/app/meson.build b/app/meson.build
index 408676b06..585b90832 100644
--- a/app/meson.build
+++ b/app/meson.build
@@ -37,7 +37,7 @@  foreach app:apps
 	# use "deps" for internal DPDK dependencies, and "ext_deps" for
 	# external package/library requirements
 	ext_deps = []
-	deps = dpdk_app_link_libraries
+	deps = []
diff --git a/meson.build b/meson.build
index 750fdeab1..d6ca58b85 100644
--- a/meson.build
+++ b/meson.build
@@ -20,7 +20,6 @@  dpdk_graph_nodes = []
 dpdk_driver_classes = []
 dpdk_drivers = []
 dpdk_extra_ldflags = []
-dpdk_app_link_libraries = []
 dpdk_libs_disabled = []
 dpdk_drvs_disabled = []
 abi_version_file = files('ABI_VERSION')