[v2,11/12] examples/vdpa: remove useless device count

Message ID 20200624122701.1369327-13-maxime.coquelin@redhat.com (mailing list archive)
State Not Applicable, archived
Delegated to: Maxime Coquelin
Headers
Series vDPA API and framework rework |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Maxime Coquelin June 24, 2020, 12:26 p.m. UTC
  The VDPA example now uses the vDPA class iterator, so
knowing the number of available devices beforehand is
no longer needed.

Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
---
 examples/vdpa/main.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)
  

Comments

Maxime Coquelin June 24, 2020, 1:42 p.m. UTC | #1
Sorry, this patch has been sent by mistake,
just discard it.

On 6/24/20 2:26 PM, Maxime Coquelin wrote:
> The VDPA example now uses the vDPA class iterator, so
> knowing the number of available devices beforehand is
> no longer needed.
> 
> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> ---
>  examples/vdpa/main.c | 9 ++-------
>  1 file changed, 2 insertions(+), 7 deletions(-)
> 
> diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
> index d59c7fa9b4..2345f98665 100644
> --- a/examples/vdpa/main.c
> +++ b/examples/vdpa/main.c
> @@ -38,7 +38,6 @@ struct vdpa_port {
>  static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS];
>  
>  static char iface[MAX_PATH_LEN];
> -static int dev_total;
>  static int devcnt;
>  static int interactive;
>  static int client_mode;
> @@ -227,7 +226,7 @@ static void
>  vdpa_sample_quit(void)
>  {
>  	int i;
> -	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
> +	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, devcnt); i++) {
>  		if (vports[i].ifname[0] != '\0')
>  			close_vdpa(&vports[i]);
>  	}
> @@ -399,7 +398,7 @@ static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
>  			res->bdf);
>  		return;
>  	}
> -	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
> +	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, devcnt); i++) {
>  		if (vports[i].dev == vdev) {
>  			vport = &vports[i];
>  			break;
> @@ -536,10 +535,6 @@ main(int argc, char *argv[])
>  	argc -= ret;
>  	argv += ret;
>  
> -	dev_total = rte_vdpa_get_device_num();
> -	if (dev_total <= 0)
> -		rte_exit(EXIT_FAILURE, "No available vdpa device found\n");
> -
>  	signal(SIGINT, signal_handler);
>  	signal(SIGTERM, signal_handler);
>  
>
  

Patch

diff --git a/examples/vdpa/main.c b/examples/vdpa/main.c
index d59c7fa9b4..2345f98665 100644
--- a/examples/vdpa/main.c
+++ b/examples/vdpa/main.c
@@ -38,7 +38,6 @@  struct vdpa_port {
 static struct vdpa_port vports[MAX_VDPA_SAMPLE_PORTS];
 
 static char iface[MAX_PATH_LEN];
-static int dev_total;
 static int devcnt;
 static int interactive;
 static int client_mode;
@@ -227,7 +226,7 @@  static void
 vdpa_sample_quit(void)
 {
 	int i;
-	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
+	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, devcnt); i++) {
 		if (vports[i].ifname[0] != '\0')
 			close_vdpa(&vports[i]);
 	}
@@ -399,7 +398,7 @@  static void cmd_device_stats_parsed(void *parsed_result, struct cmdline *cl,
 			res->bdf);
 		return;
 	}
-	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, dev_total); i++) {
+	for (i = 0; i < RTE_MIN(MAX_VDPA_SAMPLE_PORTS, devcnt); i++) {
 		if (vports[i].dev == vdev) {
 			vport = &vports[i];
 			break;
@@ -536,10 +535,6 @@  main(int argc, char *argv[])
 	argc -= ret;
 	argv += ret;
 
-	dev_total = rte_vdpa_get_device_num();
-	if (dev_total <= 0)
-		rte_exit(EXIT_FAILURE, "No available vdpa device found\n");
-
 	signal(SIGINT, signal_handler);
 	signal(SIGTERM, signal_handler);