diff mbox series

[v2,11/42] net/e1000/base: modify fall through code comments

Message ID 20200624075337.6768-12-guinanx.sun@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Qi Zhang
Headers show
Series update e1000 base code | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/checkpatch warning coding style issues

Commit Message

Guinan Sun June 24, 2020, 7:53 a.m. UTC
Found some inconsistent code comments when it came to when we "fall
through", so made them more consistent and non-repetitive.

Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/e1000/base/e1000_82575.c | 7 +++++++
 1 file changed, 7 insertions(+)
diff mbox series

Patch

diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c
index bf193eb9e..f4856af9c 100644
--- a/drivers/net/e1000/base/e1000_82575.c
+++ b/drivers/net/e1000/base/e1000_82575.c
@@ -1560,14 +1560,21 @@  STATIC s32 e1000_setup_copper_link_82575(struct e1000_hw *hw)
 	}
 	switch (hw->phy.type) {
 	case e1000_phy_i210:
+	/* fall through */
 	case e1000_phy_m88:
 		switch (hw->phy.id) {
 		case I347AT4_E_PHY_ID:
+		/* fall through */
 		case M88E1112_E_PHY_ID:
+		/* fall through */
 		case M88E1340M_E_PHY_ID:
+		/* fall through */
 		case M88E1543_E_PHY_ID:
+		/* fall through */
 		case M88E1512_E_PHY_ID:
+		/* fall through */
 		case I210_I_PHY_ID:
+		/* fall through */
 			ret_val = e1000_copper_link_setup_m88_gen2(hw);
 			break;
 		default: