diff mbox series

[v2,09/42] net/e1000/base: fall through explicitly

Message ID	20200624075337.6768-10-guinanx.sun@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	Qi Zhang
Headers	IronPort-SDR: s5dzO9tM2UjwCgMknuo4l9rS5xWN9FZvShimvOB2CrscLCpix+l5+xSbFU4cwBKOiS+giRJp7o S2BxnwVu1dNg== IronPort-SDR: /N9MpD0QmTW+bbyMVDEg3jW08+2YQTKysSXmxg2T3r4JI+DPP40mpEujnmJ2EtLGQnFN95vgSV 51fyg3I074Gg== From: Guinan Sun <guinanx.sun@intel.com> To: dev@dpdk.org Cc: Jeff Guo <jia.guo@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>, Guinan Sun <guinanx.sun@intel.com>, Todd Fujinaka <todd.fujinaka@intel.com> Date: Wed, 24 Jun 2020 07:53:04 +0000 Message-Id: <20200624075337.6768-10-guinanx.sun@intel.com> In-Reply-To: <20200624075337.6768-1-guinanx.sun@intel.com> References: <20200622064634.70941-1-guinanx.sun@intel.com> <20200624075337.6768-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH v2 09/42] net/e1000/base: fall through explicitly Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	update e1000 base code \| [v2,00/42] update e1000 base code [v2,01/42] net/e1000/base: resolve flash presence for i210 devices [v2,02/42] net/e1000/base: i210 slow system clock update [v2,03/42] net/e1000/base: add ICL device id's [v2,04/42] net/e1000/base: remove shadowing variable declarations [v2,05/42] net/e1000/base: introduce flags [v2,06/42] net/e1000/base: modify MAC initialization for i211 [v2,07/42] net/e1000/base: modify parens to match other MAC checks [v2,08/42] net/e1000/base: expose xmdio methods [v2,09/42] net/e1000/base: fall through explicitly [v2,10/42] net/e1000/base: add function parameter descriptions [v2,11/42] net/e1000/base: modify fall through code comments [v2,12/42] net/e1000/base: modify klocwork errors [v2,13/42] net/e1000/base: modify klockwork about unused return values [v2,14/42] net/e1000/base: improve coding style [v2,15/42] net/e1000/base: modify HW level time sync mechanisms [v2,16/42] net/e1000/base: modify description [v2,17/42] net/e1000/base: remove duplicated codes from 82575 [v2,18/42] net/e1000/base: add definitions for ETQF register bit [v2,19/42] net/e1000/base: cleanup duplicate declaration [v2,20/42] net/e1000/base: expose MAC functions [v2,21/42] net/e1000/base: move definitions from 82575 to defines file [v2,22/42] net/e1000/base: add define to PCIm function state [v2,23/42] net/e1000/base: add missing register defines [v2,24/42] net/e1000/base: move the device reset definition [v2,25/42] net/e1000/base: increased timeout for ME ULP exit [v2,26/42] net/e1000/base: add missing device ID [v2,27/42] net/e1000/base: expose more future extended NVM [v2,28/42] net/e1000/base: add definition of EEE 2.5G setup register [v2,29/42] net/e1000/base: remove definitions [v2,30/42] net/e1000/base: remove useless statement [v2,31/42] net/e1000/base: add missed define for VFTA [v2,32/42] net/e1000/base: modify flow control setup [v2,33/42] net/e1000/base: led blinking fix for i210 [v2,34/42] net/e1000/base: expose new FEXTNVM registers and masks [v2,35/42] net/e1000/base: cleanup duplicate defines [v2,36/42] net/e1000/base: add support for Nahum10 [v2,37/42] net/e1000/base: add fall-through comments for switch cases [v2,38/42] net/e1000/base: modify typo in Alder Lake brand name [v2,39/42] net/e1000/base: introduce DPGFR register [v2,40/42] net/e1000/base: remove conditional compilation wrapper [v2,41/42] net/e1000/base: modify copyright [v2,42/42] net/e1000/base: update version

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues
ci/Intel-compilation	success	Compilation OK

Commit Message

Guinan Sun June 24, 2020, 7:53 a.m. UTC

  This patch adds/changes fall through comments to address new warnings
produced by gcc 7.

Signed-off-by: Todd Fujinaka <todd.fujinaka@intel.com>
Signed-off-by: Guinan Sun <guinanx.sun@intel.com>
---
 drivers/net/e1000/base/e1000_82575.c | 2 +-
 drivers/net/e1000/base/e1000_mbx.c   | 1 +
 drivers/net/e1000/base/e1000_phy.c   | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/net/e1000/base/e1000_82575.c b/drivers/net/e1000/base/e1000_82575.c
index 146a7ee41..0fa0e8310 100644
--- a/drivers/net/e1000/base/e1000_82575.c
+++ b/drivers/net/e1000/base/e1000_82575.c
@@ -1779,7 +1779,7 @@  STATIC s32 e1000_get_media_type_82575(struct e1000_hw *hw)
 			dev_spec->sgmii_active = true;
 			break;
 		}
-		/* fall through for I2C based SGMII */
+		/* Fall through for I2C based SGMII */
 	case E1000_CTRL_EXT_LINK_MODE_PCIE_SERDES:
 		/* read media type from SFP EEPROM */
 		ret_val = e1000_set_sfp_media_type_82575(hw);
diff --git a/drivers/net/e1000/base/e1000_mbx.c b/drivers/net/e1000/base/e1000_mbx.c
index 6fae6767f..4cac3642e 100644
--- a/drivers/net/e1000/base/e1000_mbx.c
+++ b/drivers/net/e1000/base/e1000_mbx.c
@@ -755,6 +755,7 @@  s32 e1000_init_mbx_params_pf(struct e1000_hw *hw)
 		mbx->stats.reqs = 0;
 		mbx->stats.acks = 0;
 		mbx->stats.rsts = 0;
+		/* Fall through */
 	default:
 		return E1000_SUCCESS;
 	}
diff --git a/drivers/net/e1000/base/e1000_phy.c b/drivers/net/e1000/base/e1000_phy.c
index e8d922147..be4786794 100644
--- a/drivers/net/e1000/base/e1000_phy.c
+++ b/drivers/net/e1000/base/e1000_phy.c
@@ -1274,6 +1274,7 @@  s32 e1000_copper_link_setup_m88_gen2(struct e1000_hw *hw)
 			phy_data |= M88E1000_PSCR_AUTO_X_1000T;
 			break;
 		}
+		/* Fall through */
 	case 0:
 	default:
 		phy_data |= M88E1000_PSCR_AUTO_X_MODE;