From patchwork Fri Jun 12 08:57:46 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bill Zhou X-Patchwork-Id: 71346 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0A9DFA00BE; Fri, 12 Jun 2020 10:57:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F38B41150; Fri, 12 Jun 2020 10:57:49 +0200 (CEST) Received: from git-send-mailer.rdmz.labs.mlnx (unknown [37.142.13.130]) by dpdk.org (Postfix) with ESMTP id 138DCDE3; Fri, 12 Jun 2020 10:57:49 +0200 (CEST) From: Bill Zhou To: dev@dpdk.org Cc: stable@dpdk.org, rasland@mellanox.com, matan@mellanox.com Date: Fri, 12 Jun 2020 11:57:46 +0300 Message-Id: <20200612085746.21139-1-dongz@mellanox.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] net/mlx5: fix LRO checksum completence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The TCP checksum includes IPV4 pseudo-header checksum and L3 payload checksum which include TCP header and TCP payload. When mlx5 LRO is enabled, HW will calculate the TCP payload checksum, PMD need complete the IPV4 pseudo-header checksum and the TCP header checksum. The mlx5_lro_update_tcp_hdr function completes the TCP header checksum, but this function using lower 4 bits of data-offset field in TCP header to get the whole TCP header length, this will cause TCP header checksum wrong calculation. Update the code using higher 4 bits of data-offset field instead of lower 4 bits. Fixes: e4c2a16eb1de ("net/mlx5: handle LRO packets in Rx queue") Cc: stable@dpdk.org Signed-off-by: Bill Zhou Acked-by: Matan Azrad --- drivers/net/mlx5/mlx5_rxtx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c index 6a17a9a5d0..e4c1c95b0e 100644 --- a/drivers/net/mlx5/mlx5_rxtx.c +++ b/drivers/net/mlx5/mlx5_rxtx.c @@ -1529,7 +1529,7 @@ mlx5_lro_update_tcp_hdr(struct rte_tcp_hdr *restrict tcp, if (cqe->lro_tcppsh_abort_dupack & MLX5_CQE_LRO_PUSH_MASK) tcp->tcp_flags |= RTE_TCP_PSH_FLAG; tcp->cksum = 0; - csum += rte_raw_cksum(tcp, (tcp->data_off & 0xF) * 4); + csum += rte_raw_cksum(tcp, (tcp->data_off >> 4) * 4); csum = ((csum & 0xffff0000) >> 16) + (csum & 0xffff); csum = (~csum) & 0xffff; if (csum == 0)