From patchwork Fri Jun 12 03:23:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Guinan Sun X-Patchwork-Id: 71328 X-Patchwork-Delegate: qi.z.zhang@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4D9FA00BE; Fri, 12 Jun 2020 05:46:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23D171BDF8; Fri, 12 Jun 2020 05:46:16 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 0448458C4 for ; Fri, 12 Jun 2020 05:46:10 +0200 (CEST) IronPort-SDR: nxs6V80ipIt1PQG8EbAcIXcexrHznLJHAopi3jAE/QnFdK6fRoKLtbzQqz6D/NyxAO6FLPzqMK ael1wTdrjBvQ== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 11 Jun 2020 20:46:10 -0700 IronPort-SDR: ZqHE4/F50BSpkdYd5zpdklQ+K/ZvllKWerZO5WC9KuJpW3rjoCMWotDSx9jMbsERQalTV6j72h D8w/FSediX2w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,501,1583222400"; d="scan'208";a="289759481" Received: from intel.sh.intel.com ([10.239.255.18]) by orsmga002.jf.intel.com with ESMTP; 11 Jun 2020 20:46:09 -0700 From: Guinan Sun To: dev@dpdk.org Cc: Guinan Sun , Piotr Skajewski Date: Fri, 12 Jun 2020 03:23:53 +0000 Message-Id: <20200612032410.20864-5-guinanx.sun@intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200612032410.20864-1-guinanx.sun@intel.com> References: <20200612032410.20864-1-guinanx.sun@intel.com> Subject: [dpdk-dev] [PATCH 04/21] net/ixgbe/base: x550em 10G NIC driver issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" With the NVM image for x550em XFI ethtool will not report the auto-negotiation feature correctly. The auto-negotiation should be "No" for supports and advertised items. Signed-off-by: Piotr Skajewski Signed-off-by: Guinan Sun --- drivers/net/ixgbe/base/ixgbe_x550.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ixgbe/base/ixgbe_x550.c b/drivers/net/ixgbe/base/ixgbe_x550.c index 3de406fd3..9fa999e01 100644 --- a/drivers/net/ixgbe/base/ixgbe_x550.c +++ b/drivers/net/ixgbe/base/ixgbe_x550.c @@ -1891,7 +1891,14 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw, else *speed = IXGBE_LINK_SPEED_10GB_FULL; } else { + *autoneg = true; + switch (hw->phy.type) { + case ixgbe_phy_x550em_xfi: + *speed = IXGBE_LINK_SPEED_1GB_FULL | + IXGBE_LINK_SPEED_10GB_FULL; + *autoneg = false; + break; case ixgbe_phy_ext_1g_t: #ifdef PREBOOT_SUPPORT *speed = IXGBE_LINK_SPEED_1GB_FULL; @@ -1925,7 +1932,6 @@ s32 ixgbe_get_link_capabilities_X550em(struct ixgbe_hw *hw, IXGBE_LINK_SPEED_1GB_FULL; break; } - *autoneg = true; } return IXGBE_SUCCESS;