diff mbox series

[RFC,v2,26/26] eal: mark old naming as deprecated

Message ID	20200605225811.26342-27-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 5 Jun 2020 15:58:11 -0700 Message-Id: <20200605225811.26342-27-stephen@networkplumber.org> In-Reply-To: <20200605225811.26342-1-stephen@networkplumber.org> References: <20200604210200.25405-1-stephen@networkplumber.org> <20200605225811.26342-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [RFC v2 26/26] eal: mark old naming as deprecated Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	Change references to master/slave to \| [RFC,v2,00/26] Change references to master/slave to [RFC,v2,01/26] eal: rename terms used for DPDK lcores [RFC,v2,02/26] kni: fix reference to master/slave process [RFC,v2,03/26] bbdev: rename master to initial lcore [RFC,v2,04/26] librte_power: change reference to rte_master_lcore [RFC,v2,05/26] drivers: replace master/slave terminolgy [RFC,v2,06/26] examples/distrutor: rename master to initial [RFC,v2,07/26] examples/bond: replace references to master lcore [RFC,v2,08/26] examples/ethtool-app: replace references to slave with worker [RFC,v2,09/26] examples/ip_pipeline: replace references to master_lcore [RFC,v2,10/26] examples/qos_{meter/sched}: replace references to master lcore [RFC,v2,11/26] examples/l3fwd: replace references to master lcore [RFC,v2,12/26] examples/l2fwd: replace references to master lcore [RFC,v2,13/26] examples/multi_process: replace references to master lcore [RFC,v2,14/26] examples/performance-thread: replace reference to master lcore [RFC,v2,15/26] examples/ptpclient: replace references to master lcore [RFC,v2,16/26] examples/ipcsec-secgw: replace references to master lcore [RFC,v2,17/26] examples: replace reference to master lcore [RFC,v2,18/26] app/test-pmd: change references to master/slave [RFC,v2,19/26] test-eventdev: replace references to slave with worker lcores [RFC,v2,20/26] app/test: repalce refernces to master/slave [RFC,v2,21/26] doc: fix incorrect reference to master process [RFC,v2,22/26] doc: update references to master/slave lcore in samples [RFC,v2,23/26] doc: replace master lcore terminology [RFC,v2,24/26] app/pdump: replace references to master/slave lcore [RFC,v2,25/26] app/test-XXX: replace reference to master/slave [RFC,v2,26/26] eal: mark old naming as deprecated

Checks

Context	Check	Description
ci/Intel-compilation	success	Compilation OK
ci/checkpatch	warning	coding style issues

Commit Message

Stephen Hemminger June 5, 2020, 10:58 p.m. UTC

  Use of old RTE_LCORE_FOREACH_SLAVE and rte_get_master_lcore_id()
are marked as deprecated.

All uses of these in DPDK itself is gone. This will cause warnings
for applications still using them.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/librte_eal/include/rte_launch.h | 4 ++--
 lib/librte_eal/include/rte_lcore.h  | 4 +++-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff mbox series

Patch

diff --git a/lib/librte_eal/include/rte_launch.h b/lib/librte_eal/include/rte_launch.h
index 9b68685d99d4..8d58ca5302a7 100644
--- a/lib/librte_eal/include/rte_launch.h
+++ b/lib/librte_eal/include/rte_launch.h
@@ -76,8 +76,8 @@  enum rte_rmt_call_initial_t {
 /**
  * Deprecated backward compatiable definitions
  */
-#define SKIP_MASTER	SKIP_INITIAL
-#define CALL_MASTER	CALL_INITIAL
+#define SKIP_MASTER _Pragma("GCC warning \"'SKIP_MASTER' is deprecated\"") SKIP_INITIAL
+#define CALL_MASTER _Pragma("GCC warning \"'CALL_MASTER' is deprecated\"") CALL_INITIAL
 
 /**
  * Launch a function on all lcores.
diff --git a/lib/librte_eal/include/rte_lcore.h b/lib/librte_eal/include/rte_lcore.h
index 069cb1f427b9..eaa7c0f0b67c 100644
--- a/lib/librte_eal/include/rte_lcore.h
+++ b/lib/librte_eal/include/rte_lcore.h
@@ -67,6 +67,7 @@  unsigned int rte_get_initial_lcore(void);
  * @return
  *   the id of the initial lcore
  */
+__rte_deprecated
 unsigned int rte_get_master_lcore(void);
 
 /**
@@ -216,7 +217,8 @@  unsigned int rte_get_next_lcore(unsigned int i, int skip_initial, int wrap);
 /**
  * Backward compatibility
  */
-#define RTE_LCORE_FOREACH_SLAVE(x)		\
+#define RTE_LCORE_FOREACH_SLAVE(x)					\
+	_Pragma("GCC warning \"'RTE_LCORE_FOREACH_SLAVE' macro is deprecated\"") \
 	RTE_LCORE_FOREACH_WORKER(x)