diff mbox series

doc: fix wrong config option

Message ID 20200512194856.46965-1-mcroce@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series doc: fix wrong config option |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot warning Travis build: failed

Commit Message

Matteo Croce May 12, 2020, 7:48 p.m. UTC 
  The documentation says that CONFIG_ENABLE_LTO enables LTO during the
build, but the correct value actually is CONFIG_RTE_ENABLE_LTO

Fixes: 098cc0fea3be ("build: add option to enable LTO")
Signed-off-by: Matteo Croce <mcroce@redhat.com>
---
 doc/guides/prog_guide/lto.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand May 13, 2020, 1:01 p.m. UTC | #1 
On Tue, May 12, 2020 at 9:49 PM Matteo Croce <mcroce@redhat.com> wrote:
>
> The documentation says that CONFIG_ENABLE_LTO enables LTO during the
> build, but the correct value actually is CONFIG_RTE_ENABLE_LTO
>
> Fixes: 098cc0fea3be ("build: add option to enable LTO")

Cc: stable@dpdk.org

> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
>  doc/guides/prog_guide/lto.rst | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/prog_guide/lto.rst b/doc/guides/prog_guide/lto.rst
> index 43f4c6337..277a6f109 100644
> --- a/doc/guides/prog_guide/lto.rst
> +++ b/doc/guides/prog_guide/lto.rst
> @@ -31,7 +31,7 @@ the whole DPDK by setting:
>
>  .. code-block:: console
>
> -    CONFIG_ENABLE_LTO=y
> +    CONFIG_RTE_ENABLE_LTO=y
>
>  in config file.
>

Reviewed-by: David Marchand <david.marchand@redhat.com>
Andrzej Ostruszka [C] May 13, 2020, 1:17 p.m. UTC | #2 
On 12/05/2020 21:48, Matteo Croce wrote:
> External Email
> 
> ----------------------------------------------------------------------
> The documentation says that CONFIG_ENABLE_LTO enables LTO during the
> build, but the correct value actually is CONFIG_RTE_ENABLE_LTO
> 
> Fixes: 098cc0fea3be ("build: add option to enable LTO")
> Signed-off-by: Matteo Croce <mcroce@redhat.com>
> ---
>   doc/guides/prog_guide/lto.rst | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/doc/guides/prog_guide/lto.rst b/doc/guides/prog_guide/lto.rst
> index 43f4c6337..277a6f109 100644
> --- a/doc/guides/prog_guide/lto.rst
> +++ b/doc/guides/prog_guide/lto.rst
> @@ -31,7 +31,7 @@ the whole DPDK by setting:
>   
>   .. code-block:: console
>   
> -    CONFIG_ENABLE_LTO=y
> +    CONFIG_RTE_ENABLE_LTO=y
>   
>   in config file.

Thank you Matteo.

Acked-by: Andrzej Ostruszka <aostruszka@marvell.com>

With regards
Andrzej Ostruszka
David Marchand May 18, 2020, 3:52 p.m. UTC | #3 
On Tue, May 12, 2020 at 9:49 PM Matteo Croce <mcroce@redhat.com> wrote:
>
> The documentation says that CONFIG_ENABLE_LTO enables LTO during the
> build, but the correct value actually is CONFIG_RTE_ENABLE_LTO
>
> Fixes: 098cc0fea3be ("build: add option to enable LTO")
Cc: stable@dpdk.org

> Signed-off-by: Matteo Croce <mcroce@redhat.com>

Reviewed-by: David Marchand <david.marchand@redhat.com>
Acked-by: Andrzej Ostruszka <aostruszka@marvell.com>


Applied, thanks.
diff mbox series

Patch

diff --git a/doc/guides/prog_guide/lto.rst b/doc/guides/prog_guide/lto.rst
index 43f4c6337..277a6f109 100644
--- a/doc/guides/prog_guide/lto.rst
+++ b/doc/guides/prog_guide/lto.rst
@@ -31,7 +31,7 @@  the whole DPDK by setting:
 
 .. code-block:: console
 
-    CONFIG_ENABLE_LTO=y
+    CONFIG_RTE_ENABLE_LTO=y
 
 in config file.