diff mbox series

common/qat: fix stats update

Message ID 20200506112943.25385-1-adamx.dybkowski@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series common/qat: fix stats update |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Dybkowski, AdamX May 6, 2020, 11:29 a.m. UTC 
  This patch fixes enqueued and dequeued count statistics that should
contain the numer of operations enqueued by the end user app
instead of the total number of QAT requests - bigger in case of
a multiple-request dynamic Huffman compression operation.

Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")

Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>

---

Requires applying other patch first: http://patches.dpdk.org/patch/69765/
---
 drivers/common/qat/qat_qp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Fiona Trahe May 8, 2020, 2:56 p.m. UTC | #1 
> -----Original Message-----
> From: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Sent: Wednesday, May 6, 2020 12:30 PM
> To: dev@dpdk.org; Trahe, Fiona <fiona.trahe@intel.com>; akhil.goyal@nxp.com
> Cc: Dybkowski, AdamX <adamx.dybkowski@intel.com>
> Subject: [PATCH] common/qat: fix stats update
> 
> This patch fixes enqueued and dequeued count statistics that should
> contain the numer of operations enqueued by the end user app
> instead of the total number of QAT requests - bigger in case of
> a multiple-request dynamic Huffman compression operation.
> 
> Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")
> 
> Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Akhil Goyal May 9, 2020, 10:03 p.m. UTC | #2 
> > This patch fixes enqueued and dequeued count statistics that should
> > contain the numer of operations enqueued by the end user app
> > instead of the total number of QAT requests - bigger in case of
> > a multiple-request dynamic Huffman compression operation.
> >
> > Fixes: c13cecf60f12 ("compress/qat: support IM buffer too small operation")
> >
> > Signed-off-by: Adam Dybkowski <adamx.dybkowski@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>

Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/drivers/common/qat/qat_qp.c b/drivers/common/qat/qat_qp.c
index 098b99786..9d7091af3 100644
--- a/drivers/common/qat/qat_qp.c
+++ b/drivers/common/qat/qat_qp.c
@@ -818,7 +818,7 @@  qat_enqueue_comp_op_burst(void *qp, void **ops, uint16_t nb_ops)
 kick_tail:
 	queue->tail = tail;
 	tmp_qp->enqueued += total_descriptors_built;
-	tmp_qp->stats.enqueued_count += total_descriptors_built;
+	tmp_qp->stats.enqueued_count += nb_ops_sent;
 	txq_write_tail(tmp_qp, queue);
 	return nb_ops_sent;
 }
@@ -880,7 +880,7 @@  qat_dequeue_op_burst(void *qp, void **ops, uint16_t nb_ops)
 	}
 
 	tmp_qp->dequeued += fw_resp_counter;
-	tmp_qp->stats.dequeued_count += fw_resp_counter;
+	tmp_qp->stats.dequeued_count += op_resp_counter;
 
 	rx_queue->head = head;
 	if (rx_queue->nb_processed_responses > QAT_CSR_HEAD_WRITE_THRESH)