diff mbox series

test/security: enable tests for non-implemented ops

Message ID 20200423162554.23529-1-l.wojciechow@partner.samsung.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series test/security: enable tests for non-implemented ops |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation success Compilation OK
ci/iol-testing fail Testing issues

Commit Message

Lukasz Wojciechowski April 23, 2020, 4:25 p.m. UTC 
  After re-enabling checks for non-implemneted ops in non-debug mode
in librte_security set_pkt_metadata and get_userdata functions,
tests verifying proper work of tests can be enabled also.

Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
---
 app/test/test_security.c | 8 --------
 1 file changed, 8 deletions(-)

Comments

Akhil Goyal May 9, 2020, 9:47 p.m. UTC | #1 
> 
> After re-enabling checks for non-implemneted ops in non-debug mode
> in librte_security set_pkt_metadata and get_userdata functions,
> tests verifying proper work of tests can be enabled also.
> 
> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
> ---
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.
Lukasz Wojciechowski May 11, 2020, 10:15 a.m. UTC | #2 
W dniu 09.05.2020 o 23:47, Akhil Goyal pisze:
>> After re-enabling checks for non-implemneted ops in non-debug mode
>> in librte_security set_pkt_metadata and get_userdata functions,
>> tests verifying proper work of tests can be enabled also.
>>
>> Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
>> ---
> Acked-by: Akhil Goyal <akhil.goyal@nxp.com>
>
> Applied to dpdk-next-crypto
>
> Thanks.
Thank you
diff mbox series

Patch

diff --git a/app/test/test_security.c b/app/test/test_security.c
index 724ce56f4..3076a4c5a 100644
--- a/app/test/test_security.c
+++ b/app/test/test_security.c
@@ -1474,7 +1474,6 @@  test_set_pkt_metadata_inv_context_ops(void)
 static int
 test_set_pkt_metadata_inv_context_ops_fun(void)
 {
-#ifdef RTE_DEBUG
 	struct security_unittest_params *ut_params = &unittest_params;
 	struct rte_mbuf m;
 	int params;
@@ -1487,9 +1486,6 @@  test_set_pkt_metadata_inv_context_ops_fun(void)
 	TEST_ASSERT_MOCK_CALLS(mock_set_pkt_metadata_exp, 0);
 
 	return TEST_SUCCESS;
-#else
-	return TEST_SKIPPED;
-#endif
 }
 
 /**
@@ -1621,7 +1617,6 @@  test_get_userdata_inv_context_ops(void)
 static int
 test_get_userdata_inv_context_ops_fun(void)
 {
-#ifdef RTE_DEBUG
 	struct security_unittest_params *ut_params = &unittest_params;
 	uint64_t md = 0xDEADBEEF;
 	ut_params->ctx.ops = &empty_ops;
@@ -1632,9 +1627,6 @@  test_get_userdata_inv_context_ops_fun(void)
 	TEST_ASSERT_MOCK_CALLS(mock_get_userdata_exp, 0);
 
 	return TEST_SUCCESS;
-#else
-	return TEST_SKIPPED;
-#endif
 }
 
 /**