diff mbox series

[v1,08/17] ip_frag: replace library debug flag with global one

Message ID 20200417215739.23180-9-l.wojciechow@partner.samsung.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series introduce global debug flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Lukasz Wojciechowski April 17, 2020, 9:57 p.m. UTC 
  Use global debug flag RTE_DEBUG instead of RTE_LIBRTE_IP_FRAG_DEBUG.
The old define is completely removed from source code and config.
The documentation was updated also.

Signed-off-by: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>
---
 config/common_base                                   | 1 -
 doc/guides/prog_guide/ip_fragment_reassembly_lib.rst | 4 ++--
 lib/librte_ip_frag/ip_frag_common.h                  | 4 ++--
 3 files changed, 4 insertions(+), 5 deletions(-)
diff mbox series

Patch

diff --git a/config/common_base b/config/common_base
index a12a869a9..44a9ab75c 100644
--- a/config/common_base
+++ b/config/common_base
@@ -956,7 +956,6 @@  CONFIG_RTE_LIBRTE_NET=y
 # Compile librte_ip_frag
 #
 CONFIG_RTE_LIBRTE_IP_FRAG=y
-CONFIG_RTE_LIBRTE_IP_FRAG_DEBUG=n
 CONFIG_RTE_LIBRTE_IP_FRAG_MAX_FRAG=4
 CONFIG_RTE_LIBRTE_IP_FRAG_TBL_STAT=n
 
diff --git a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst
index 6ac1bba64..b48ccfbbf 100644
--- a/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst
+++ b/doc/guides/prog_guide/ip_fragment_reassembly_lib.rst
@@ -104,7 +104,7 @@  Debug logging and Statistics Collection
 The RTE_LIBRTE_IP_FRAG_TBL_STAT config macro controls statistics collection for the Fragment Table.
 This macro is not enabled by default.
 
-The RTE_LIBRTE_IP_FRAG_DEBUG controls debug logging of IP fragments processing and reassembling.
-This macro is disabled by default.
+The RTE_DEBUG controls debug logging of IP fragments processing and reassembling.
+This macro is disabled by default and can be enabled using meson "debug" option.
 Note that while logging contains a lot of detailed information,
 it slows down packet processing and might cause the loss of a lot of packets.
diff --git a/lib/librte_ip_frag/ip_frag_common.h b/lib/librte_ip_frag/ip_frag_common.h
index a17a74076..79a0dbd18 100644
--- a/lib/librte_ip_frag/ip_frag_common.h
+++ b/lib/librte_ip_frag/ip_frag_common.h
@@ -8,11 +8,11 @@ 
 #include "rte_ip_frag.h"
 
 /* logging macros. */
-#ifdef RTE_LIBRTE_IP_FRAG_DEBUG
+#ifdef RTE_DEBUG
 #define	IP_FRAG_LOG(lvl, fmt, args...)	RTE_LOG(lvl, USER1, fmt, ##args)
 #else
 #define	IP_FRAG_LOG(lvl, fmt, args...)	do {} while(0)
-#endif /* IP_FRAG_DEBUG */
+#endif /* RTE_DEBUG */
 
 #define IPV4_KEYLEN 1
 #define IPV6_KEYLEN 4