diff mbox series

examples/vm_power_manager: fix build

Message ID 20200417185534.2285671-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Headers
Series examples/vm_power_manager: fix build |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing fail Testing issues
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Ferruh Yigit April 17, 2020, 6:55 p.m. UTC 
  Build fails because '__rte_unused' macro not defined in file, error
produced by 'i686-native-linux-gcc config' but it seems generic issue.

Build error:
.../examples/vm_power_manager/oob_monitor_nop.c:11:13:
   error: expected ‘;’ before ‘static’
   11 | __rte_unused static float
      |             ^~~~~~~
      |             ;
.../examples/vm_power_manager/oob_monitor_nop.c:12:14:
   error: unknown type name ‘__rte_unused’
   12 | apply_policy(__rte_unused int core)
      |              ^~~~~~~~~~~~
.../examples/vm_power_manager/oob_monitor_nop.c:18:21:
   error: unknown type name ‘__rte_unused’
   18 | add_core_to_monitor(__rte_unused int core)
      |                     ^~~~~~~~~~~~
.../examples/vm_power_manager/oob_monitor_nop.c:24:26:
   error: unknown type name ‘__rte_unused’
   24 | remove_core_from_monitor(__rte_unused int core)
      |                          ^~~~~~~~~~~~

Including 'rte_common.h' header which defines the macro for fix.

Fixes: f2fc83b40f06 ("replace unused attributes")

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: thomas@monjalon.net
---
 examples/vm_power_manager/oob_monitor_nop.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Monjalon April 17, 2020, 9:14 p.m. UTC | #1 
17/04/2020 20:55, Ferruh Yigit:
> Build fails because '__rte_unused' macro not defined in file, error
> produced by 'i686-native-linux-gcc config' but it seems generic issue.
> 
> Build error:
> .../examples/vm_power_manager/oob_monitor_nop.c:11:13:
>    error: expected ‘;’ before ‘static’
>    11 | __rte_unused static float
>       |             ^~~~~~~
>       |             ;
> .../examples/vm_power_manager/oob_monitor_nop.c:12:14:
>    error: unknown type name ‘__rte_unused’
>    12 | apply_policy(__rte_unused int core)
>       |              ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:18:21:
>    error: unknown type name ‘__rte_unused’
>    18 | add_core_to_monitor(__rte_unused int core)
>       |                     ^~~~~~~~~~~~
> .../examples/vm_power_manager/oob_monitor_nop.c:24:26:
>    error: unknown type name ‘__rte_unused’
>    24 | remove_core_from_monitor(__rte_unused int core)
>       |                          ^~~~~~~~~~~~
> 
> Including 'rte_common.h' header which defines the macro for fix.
> 
> Fixes: f2fc83b40f06 ("replace unused attributes")
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

The file oob_monitor_nop.c is not compiled on x86_64.
Unfortunately, my build matrix does not include vm_power_manager
on i686.

Applied, thanks
diff mbox series

Patch

diff --git a/examples/vm_power_manager/oob_monitor_nop.c b/examples/vm_power_manager/oob_monitor_nop.c
index fc73ce18e..08dc6a72d 100644
--- a/examples/vm_power_manager/oob_monitor_nop.c
+++ b/examples/vm_power_manager/oob_monitor_nop.c
@@ -2,6 +2,8 @@ 
  * Copyright(c) 2010-2014 Intel Corporation
  */
 
+#include <rte_common.h>
+
 #include "oob_monitor.h"
 
 void branch_monitor_exit(void)