[v2] doc: use glob terminology
Checks
Commit Message
From: Jerin Jacob <jerinj@marvell.com>
Glob is the terminology used in fnmatch man page.
Use glob terminology across DPDK for shell pattern.
Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
v2:
- Fix typo
devtools/check-includes.sh | 2 +-
lib/librte_eal/include/rte_log.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.25.1
Comments
12/04/2020 17:04, jerinj@marvell.com:
> --- a/devtools/check-includes.sh
> +++ b/devtools/check-includes.sh
> @@ -23,7 +23,7 @@
> # PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
> # C/C++ compilation flags.
> #
> -# IGNORE contains a list of shell patterns matching files (relative to the
> +# IGNORE contains a list of glob matching files (relative to the
> # include directory) to avoid. It is set by default to known DPDK headers
> # which must not be included on their own.
> #
> diff --git a/lib/librte_eal/include/rte_log.h b/lib/librte_eal/include/rte_log.h
> index a497e195d..fa60177c0 100644
> --- a/lib/librte_eal/include/rte_log.h
> +++ b/lib/librte_eal/include/rte_log.h
> @@ -158,7 +158,7 @@ __rte_experimental
> bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
>
> /**
> - * Set the log level for a given type based on shell pattern.
> + * Set the log level for a given type based on glob.
> *
> * @param pattern
> * The match pattern identifying the log type.
My comment on v1 was sent at the same time as this v2. Pasting it here:
"match pattern" can be replaced with "globbing pattern".
I think there are few other places which can be improved.
I see this one in lib/librte_eal/common/eal_common_log.c:
glob (file match) pattern
I suggest "globbing pattern"
And "Glob match string option" -> "Globbing pattern option"
@@ -23,7 +23,7 @@
# PEDANTIC_CFLAGS, PEDANTIC_CXXFLAGS and PEDANTIC_CPPFLAGS provide strict
# C/C++ compilation flags.
#
-# IGNORE contains a list of shell patterns matching files (relative to the
+# IGNORE contains a list of glob matching files (relative to the
# include directory) to avoid. It is set by default to known DPDK headers
# which must not be included on their own.
#
@@ -158,7 +158,7 @@ __rte_experimental
bool rte_log_can_log(uint32_t logtype, uint32_t loglevel);
/**
- * Set the log level for a given type based on shell pattern.
+ * Set the log level for a given type based on glob.
*
* @param pattern
* The match pattern identifying the log type.