| Message ID | 20200310065036.4396-1-muhammad.ahmad@emumba.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Thomas Monjalon |
| Headers | show |
| Series | lib/librte_net/rte_ether.h:changed RTE_ETHER_MAX_LEN | expand |
| Context | Check | Description |
|---|---|---|
| ci/Intel-compilation | success | Compilation OK |
| ci/travis-robot | success | Travis build: passed |
| ci/iol-mellanox-Performance | success | Performance Testing PASS |
| ci/iol-testing | success | Testing PASS |
| ci/checkpatch | success | coding style OK |
On Tue, 10 Mar 2020 11:50:36 +0500 Muhammad Ahmad <muhammad.ahmad@emumba.com> wrote: > Change the RTE_ETHER_MAX_LEN from 1518 to 1526 > > Bugzilla ID: 296 > > Fixes: c5b2d13 (net: add rte prefix to ether defines) > > Cc: stable@dpdk.org > Cc: Oliver Matz <olivier.matz@6wind.com> > > Reported-by: LAVA <lavaraj@gmail.com> > Suggested-by: LAVA <lavaraj@gmail.com> > Signed-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com> > --- > lib/librte_net/rte_ether.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h > index e069dc7fe..8953107f3 100644 > --- a/lib/librte_net/rte_ether.h > +++ b/lib/librte_net/rte_ether.h > @@ -30,7 +30,7 @@ extern "C" { > (RTE_ETHER_ADDR_LEN * 2 + \ > RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */ > #define RTE_ETHER_MIN_LEN 64 /**< Minimum frame len, including CRC. */ > -#define RTE_ETHER_MAX_LEN 1518 /**< Maximum frame len, including CRC. */ > +#define RTE_ETHER_MAX_LEN 1526 /**< Maximum frame len, including CRC. */ > #define RTE_ETHER_MTU \ > (RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \ > RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */ No that is abi change would impact a lot of code and drivers. The problem is the comment is wrong, not the value.
diff --git a/lib/librte_net/rte_ether.h b/lib/librte_net/rte_ether.h index e069dc7fe..8953107f3 100644 --- a/lib/librte_net/rte_ether.h +++ b/lib/librte_net/rte_ether.h @@ -30,7 +30,7 @@ extern "C" { (RTE_ETHER_ADDR_LEN * 2 + \ RTE_ETHER_TYPE_LEN) /**< Length of Ethernet header. */ #define RTE_ETHER_MIN_LEN 64 /**< Minimum frame len, including CRC. */ -#define RTE_ETHER_MAX_LEN 1518 /**< Maximum frame len, including CRC. */ +#define RTE_ETHER_MAX_LEN 1526 /**< Maximum frame len, including CRC. */ #define RTE_ETHER_MTU \ (RTE_ETHER_MAX_LEN - RTE_ETHER_HDR_LEN - \ RTE_ETHER_CRC_LEN) /**< Ethernet MTU. */
Change the RTE_ETHER_MAX_LEN from 1518 to 1526 Bugzilla ID: 296 Fixes: c5b2d13 (net: add rte prefix to ether defines) Cc: stable@dpdk.org Cc: Oliver Matz <olivier.matz@6wind.com> Reported-by: LAVA <lavaraj@gmail.com> Suggested-by: LAVA <lavaraj@gmail.com> Signed-off-by: Muhammad Ahmad <muhammad.ahmad@emumba.com> --- lib/librte_net/rte_ether.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)