| Message ID | 20200309065106.23800-8-mattias.ronnblom@ericsson.com (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Delegated to: | Jerin Jacob |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1DC93A052E; Mon, 9 Mar 2020 07:53:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 16F881BFF4; Mon, 9 Mar 2020 07:52:03 +0100 (CET) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-eopbgr60089.outbound.protection.outlook.com [40.107.6.89]) by dpdk.org (Postfix) with ESMTP id 790891C002 for <dev@dpdk.org>; Mon, 9 Mar 2020 07:51:52 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QDnbTtdNa1MonUJDeeafOQBznssaGcNWT9Wq9Huly7fhXXfIjJSY+HhiQCfGdzX7RUMpCKuDrJt5IIJ5iuGNh0S4fKCR0N2oyajYDFa9COZjyBLuz4d6eJb7On2szTShzOTuzhsGSooxESiZnGFcnRQ3tvkvOKSR0zuiw9iWlIVazSqTC8BeMNVTq6mNy4zZq4FUh4k1mnzukUDrK1PNz0GvpMQ1rcbSZSUuyabg/Va7nZbLnCS+cgcd/SZs2z9Q+zFmaXzufV+qMxH7gTuDQvJOP9HxBINKCSjJA+8i7F8GnxH9ESVAbHUaNYm33kQxUfRTrikCXjxxaKZRh6SOmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hXlF0Ntdwl5BfpK3RMTZfyx5WPhzi8CRQfvlPJAu08=; b=DKA7hRxwAZjxQsd6H8/EqSk7JnBTGxJYk1PEZlUEj/fO6sPLrawiEUm1h52jmWZkAvuR1A9prh1rrvtc3X+N/CCN4MFMWfx/f8AVFytMDJ5Nzc8j625FdgGfHHUKTnZbh/z3Nxi/RuvMK4nKrUetRxkfCe22WSdv5RjIs63YZEITMgImt/cymRCxQ5PB9wobHiFV5d1PTr6O5cZzsnvY9oxD/nTHhru7DUefLj37envETHZWEb7NEfNO4YdqJASXOA7HPM0Z96LGlgjKOBkkPvtmnfnWlrGFSdPefW+6lli7MvzOqvu78dBk5iFEtZvw3/azdmECMraxte11Op6Iyg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=arm.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=none pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4hXlF0Ntdwl5BfpK3RMTZfyx5WPhzi8CRQfvlPJAu08=; b=kA4vsmo/LxCWKZ7Iz8xvKwMwmSRZNbtfWR2JnWDze18Iw3uFQmAGRx3Aes9YYB9bZXv4QYQN+SSVBy50/3JDOPhj4NKRkXzv4stkkcqDjyyRflShZ8QgAWtQc93oBOKXs6b50K1R7PcViAI2iqgVRwuGauxEaod4xzVx/SnoZM4= Received: from AM0PR02CA0021.eurprd02.prod.outlook.com (2603:10a6:208:3e::34) by VI1PR07MB6432.eurprd07.prod.outlook.com (2603:10a6:800:137::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2814.9; Mon, 9 Mar 2020 06:51:51 +0000 Received: from HE1EUR02FT045.eop-EUR02.prod.protection.outlook.com (2603:10a6:208:3e:cafe::10) by AM0PR02CA0021.outlook.office365.com (2603:10a6:208:3e::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2793.15 via Frontend Transport; Mon, 9 Mar 2020 06:51:51 +0000 Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; Received: from oa.msg.ericsson.com (192.176.1.74) by HE1EUR02FT045.mail.protection.outlook.com (10.152.11.238) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2793.11 via Frontend Transport; Mon, 9 Mar 2020 06:51:51 +0000 Received: from ESESSMB503.ericsson.se (153.88.183.164) by ESESSMR502.ericsson.se (153.88.183.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1713.5; Mon, 9 Mar 2020 07:51:44 +0100 Received: from selio1a020.lmera.ericsson.se (153.88.183.153) by smtp.internal.ericsson.com (153.88.183.191) with Microsoft SMTP Server id 15.1.1713.5 via Frontend Transport; Mon, 9 Mar 2020 07:51:43 +0100 Received: from breslau.lmera.ericsson.se (breslau.lmera.ericsson.se [150.132.109.241]) by selio1a020.lmera.ericsson.se (8.15.1+Sun/8.15.1) with ESMTP id 0296pgIR024126; Mon, 9 Mar 2020 07:51:43 +0100 (CET) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com> To: <jerinj@marvell.com> CC: <dev@dpdk.org>, <stefan.sundkvist@ericsson.com>, <Ola.Liljedahl@arm.com>, =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com> Date: Mon, 9 Mar 2020 07:51:05 +0100 Message-ID: <20200309065106.23800-8-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200309065106.23800-1-mattias.ronnblom@ericsson.com> References: <20200309065106.23800-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.176.1.74; IPV:; CTRY:SE; EFV:NLI; SFV:NSPM; SFS:(10009020)(4636009)(39860400002)(346002)(136003)(376002)(396003)(199004)(189003)(356004)(6666004)(6916009)(2906002)(5660300002)(478600001)(2616005)(956004)(86362001)(70586007)(70206006)(246002)(186003)(316002)(54906003)(8676002)(36756003)(8936002)(107886003)(1076003)(4326008)(26005)(4744005)(7636002)(336012); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR07MB6432; H:oa.msg.ericsson.com; FPR:; SPF:Pass; LANG:en; PTR:office365.se.ericsson.net; A:1; MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5f836b74-65e8-430c-c009-08d7c3f658c0 X-MS-TrafficTypeDiagnostic: VI1PR07MB6432: X-Microsoft-Antispam-PRVS: <VI1PR07MB6432A86A925664CFFD28DA0EE1FE0@VI1PR07MB6432.eurprd07.prod.outlook.com> X-MS-Oob-TLC-OOBClassifiers: OLM:4941; X-Forefront-PRVS: 0337AFFE9A X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KT12q2O5HyKX0MYnan2N53klHfnMJqSkD+WcnIJ8no0/FdYeJet7C2JDUrC4zKzOUaGIkqaYnc8/nDxhn1nHLP5qrQeMtIKm2tzS/jtwUKhM8tlbHsa0XCeHowFXGOc198LwM/N3Ut0rrfZ9ZAtXeVguLYMlwhn9WMdiqJSOFgYAPdh1Dq25ADsCCK9+uoS+INFTngFdvthpzixKi33HDIasbbHUtNAWaknKru6fkcEN9qzLo0/TImBp/DTUOsnK54pLgrsx2shwNU7OxafPj8Mv5yfvaWJF9Cjj9P1/PlOF/yaqJ/VYx0QMq2L6JosOBCyESnFS1FPpQD3QzVk1Evj/MpLqW5/Fs5iD6pG64SE+XVLCmuCUKfqSKT1PAYMk5o/yhuWFd60KBbo9ehTkrAhX9wD1lVZMDX28wLAJlG9dIgn79EUThTr/0C/9+a8V X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2020 06:51:51.4342 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5f836b74-65e8-430c-c009-08d7c3f658c0 X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR07MB6432 Subject: [dpdk-dev] [PATCH 7/8] event/dsw: remove unnecessary read barrier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
DSW performance and statistics improvements
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | fail | apply issues |
Commit Message
Mattias Rönnblom
March 9, 2020, 6:51 a.m. UTC
Remove unnecessary read barrier (and misleading comment) on control
message dequeue.
Fixes: f6257b22e767 ("event/dsw: add load balancing")
Suggested-by: Ola Liljedahl <Ola.Liljedahl@arm.com>
Signed-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>
---
drivers/event/dsw/dsw_event.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c index bb06df803..73a9d38cb 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c @@ -1068,11 +1068,6 @@ dsw_port_ctl_process(struct dsw_evdev *dsw, struct dsw_port *port) { struct dsw_ctl_msg msg; - /* So any table loads happens before the ring dequeue, in the - * case of a 'paus' message. - */ - rte_smp_rmb(); - if (dsw_port_ctl_dequeue(port, &msg) == 0) { switch (msg.type) { case DSW_CTL_PAUS_REQ: