diff mbox series

[v7,15/17] test/ring: adjust run-on-all-cores perf test cases

Message ID 20191220044524.32910-16-honnappa.nagarahalli@arm.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers show
Series lib/ring: APIs to support custom element size | expand

Checks

Context Check Description
ci/Intel-compilation fail Compilation issues
ci/checkpatch success coding style OK

Commit Message

Honnappa Nagarahalli Dec. 20, 2019, 4:45 a.m. UTC
Adjust run-on-all-cores test case to use legacy APIs.

Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Reviewed-by: Gavin Hu <gavin.hu@arm.com>
---
 app/test/test_ring_perf.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Ananyev, Konstantin Jan. 2, 2020, 5 p.m. UTC | #1
> 
> Adjust run-on-all-cores test case to use legacy APIs.
> 
> Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> ---
>  app/test/test_ring_perf.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c
> index b893b5779..fb95e4f2c 100644
> --- a/app/test/test_ring_perf.c
> +++ b/app/test/test_ring_perf.c
> @@ -520,6 +520,9 @@ test_ring_perf(void)
>  					dequeue_bulk) < 0)
>  			return -1;
>  	}
> +	printf("\n### Testing using all slave nodes ###\n");
> +	if (run_on_all_cores(r) < 0)
> +		return -1;
>  	rte_ring_free(r);
> 
>  	TEST_RING_CREATE(RING_NAME, 16, RING_SIZE, rte_socket_id(), 0, r);
> @@ -567,9 +570,6 @@ test_ring_perf(void)
>  			return -1;
>  	}
> 
> -	printf("\n### Testing using all slave nodes ###\n");
> -	run_on_all_cores(r);
> -

No run_on_all_cores() for 16B elems case?

>  	rte_ring_free(r);
> 
>  	return 0;
>
Honnappa Nagarahalli Jan. 7, 2020, 5:42 a.m. UTC | #2
<snip>

> 
> >
> > Adjust run-on-all-cores test case to use legacy APIs.
> >
> > Signed-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> > Reviewed-by: Gavin Hu <gavin.hu@arm.com>
> > ---
> >  app/test/test_ring_perf.c | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c
> > index b893b5779..fb95e4f2c 100644
> > --- a/app/test/test_ring_perf.c
> > +++ b/app/test/test_ring_perf.c
> > @@ -520,6 +520,9 @@ test_ring_perf(void)
> >  					dequeue_bulk) < 0)
> >  			return -1;
> >  	}
> > +	printf("\n### Testing using all slave nodes ###\n");
> > +	if (run_on_all_cores(r) < 0)
> > +		return -1;
> >  	rte_ring_free(r);
> >
> >  	TEST_RING_CREATE(RING_NAME, 16, RING_SIZE, rte_socket_id(), 0,
> r);
> > @@ -567,9 +570,6 @@ test_ring_perf(void)
> >  			return -1;
> >  	}
> >
> > -	printf("\n### Testing using all slave nodes ###\n");
> > -	run_on_all_cores(r);
> > -
> 
> No run_on_all_cores() for 16B elems case?
Ok, I can add.

> 
> >  	rte_ring_free(r);
> >
> >  	return 0;
> >
diff mbox series

Patch

diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c
index b893b5779..fb95e4f2c 100644
--- a/app/test/test_ring_perf.c
+++ b/app/test/test_ring_perf.c
@@ -520,6 +520,9 @@  test_ring_perf(void)
 					dequeue_bulk) < 0)
 			return -1;
 	}
+	printf("\n### Testing using all slave nodes ###\n");
+	if (run_on_all_cores(r) < 0)
+		return -1;
 	rte_ring_free(r);
 
 	TEST_RING_CREATE(RING_NAME, 16, RING_SIZE, rte_socket_id(), 0, r);
@@ -567,9 +570,6 @@  test_ring_perf(void)
 			return -1;
 	}
 
-	printf("\n### Testing using all slave nodes ###\n");
-	run_on_all_cores(r);
-
 	rte_ring_free(r);
 
 	return 0;