diff mbox series

lib/cfgfile: update map file

Message ID 20191217104347.21955-1-lironh@marvell.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series lib/cfgfile: update map file |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot warning Travis build: failed
ci/Intel-compilation fail apply issues

Commit Message

Liron Himi Dec. 17, 2019, 10:43 a.m. UTC 
  From: Liron Himi <lironh@marvell.com>

rte_cfgfile_section_num_entries_by_index was missing from the map
file.
meson build failed when calling this function

Signed-off-by: Liron Himi <lironh@marvell.com>
---
 lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
 1 file changed, 1 insertion(+)

Comments

David Marchand Dec. 17, 2019, 8:43 a.m. UTC | #1 
Comment on the patch title, we never prefix titles with lib/.
This is implicit and just makes the title longer.

Please look at the dpdk git history.
I would go with the 'cfgfile: ' prefix.


On Tue, Dec 17, 2019 at 9:28 AM <lironh@marvell.com> wrote:
>
> From: Liron Himi <lironh@marvell.com>
>
> rte_cfgfile_section_num_entries_by_index was missing from the map
> file.
> meson build failed when calling this function

The problem is not linked to meson, but linking a binary to cfgfile
built as a shared library.


We are missing a Fixes: line and a Cc: stable@dpdk.org (the backport
won't apply cleanly though).

>
> Signed-off-by: Liron Himi <lironh@marvell.com>
> ---
>  lib/librte_cfgfile/rte_cfgfile_version.map | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
> index 906eee96b..b0389e7d8 100644
> --- a/lib/librte_cfgfile/rte_cfgfile_version.map
> +++ b/lib/librte_cfgfile/rte_cfgfile_version.map
> @@ -14,6 +14,7 @@ DPDK_20.0 {
>         rte_cfgfile_save;
>         rte_cfgfile_section_entries;
>         rte_cfgfile_section_entries_by_index;
> +       rte_cfgfile_section_num_entries_by_index;

Those entries must be sorted in alphabetical order.

>         rte_cfgfile_section_num_entries;
>         rte_cfgfile_sections;
>         rte_cfgfile_set_entry;
> --
> 2.23.0
>
diff mbox series

Patch

diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgfile/rte_cfgfile_version.map
index 906eee96b..b0389e7d8 100644
--- a/lib/librte_cfgfile/rte_cfgfile_version.map
+++ b/lib/librte_cfgfile/rte_cfgfile_version.map
@@ -14,6 +14,7 @@  DPDK_20.0 {
 	rte_cfgfile_save;
 	rte_cfgfile_section_entries;
 	rte_cfgfile_section_entries_by_index;
+	rte_cfgfile_section_num_entries_by_index;
 	rte_cfgfile_section_num_entries;
 	rte_cfgfile_sections;
 	rte_cfgfile_set_entry;