From patchwork Thu Dec 5 13:30:08 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lu Qiuwen X-Patchwork-Id: 63595 X-Patchwork-Delegate: xiaolong.ye@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 676E9A04F2; Thu, 5 Dec 2019 14:30:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F10091BF8D; Thu, 5 Dec 2019 14:30:29 +0100 (CET) Received: from cstnet.cn (smtp23.cstnet.cn [159.226.251.23]) by dpdk.org (Postfix) with ESMTP id 02F4E1BF8B; Thu, 5 Dec 2019 14:30:27 +0100 (CET) Received: from localhost.localdomain (unknown [202.43.148.188]) by APP-03 (Coremail) with SMTP id rQCowABHT99tBuldvwulBw--.34465S2; Thu, 05 Dec 2019 21:30:26 +0800 (CST) From: Lu Qiuwen To: Qi Zhang , Xiao Wang Cc: dev@dpdk.org, jeffrey.b.shaw@intel.com, stable@dpdk.org Date: Thu, 5 Dec 2019 21:30:08 +0800 Message-Id: <20191205133008.4464-1-luqiuwen@iie.ac.cn> X-Mailer: git-send-email 2.17.1 X-CM-TRANSID: rQCowABHT99tBuldvwulBw--.34465S2 X-Coremail-Antispam: 1UD129KBjvdXoWrtw1xuFWrWF15ZFWUtr18Krg_yoWDCFX_Cr ZrZF48GryjkanFkrsrZFyxXryakF1jgr409rW7tr9ag3s8Zas8CFy2vFnrJr17GrW8CFy7 tw13X34xCrWavjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUIcSsGvfJTRUUUb28YjsxI4VWkKwAYFVCjjxCrM7AC8VAFwI0_Jr0_Gr1l1xkIjI8I 6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr0_Jr4l8cAvFVAK0II2c7xJM2 8CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AKxVWUJVWUCwA2z4x0Y4vE2Ix0 cI8IcVCY1x0267AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIE14v26F4UJVW0owA2z4x0Y4vEx4 A2jsIEc7CjxVAFwI0_GcCE3s1le2I262IYc4CY6c8Ij28IcVAaY2xG8wAqx4xG64xvF2IE w4CE5I8CrVC2j2WlYx0E2Ix0cI8IcVAFwI0_Jr0_Jr4lYx0Ex4A2jsIE14v26F4j6r4UJw Am72CE4IkC6x0Yz7v_Jr0_Gr1lF7xvr2IYc2Ij64vIr41lc2xSY4AK67AK6ry8MxAIw28I cxkI7VAKI48JMxC20s026xCaFVCjc4AY6r1j6r4UMI8I3I0E5I8CrVAFwI0_Jr0_Jr4lx2 IqxVCjr7xvwVAFwI0_JrI_JrWlx4CE17CEb7AF67AKxVWUAVWUtwCIc40Y0x0EwIxGrwCI 42IY6xIIjxv20xvE14v26r1j6r1xMIIF0xvE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwCI42 IY6xAIw20EY4v20xvaj40_WFyUJVCq3wCI42IY6I8E87Iv67AKxVWUJVW8JwCI42IY6I8E 87Iv6xkF7I0E14v26r1j6r4UYxBIdaVFxhVjvjDU0xZFpf9x07brUUbUUUUU= X-Originating-IP: [202.43.148.188] X-CM-SenderInfo: 5oxtx3xzhqqx1lhotugofq/ Subject: [dpdk-dev] [PATCH] net/fm10k: fix descriptor vlan field filling in Tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The VLAN field in the descriptor is not filled when ol_flags has no VLAN flag. When the caller sends some packets with VLAN tags, but other packets do not have VLAN tags, the behavior of the program cannot be determined. Fixes: 4b61d3bfa941 ("fm10k: add receive and tranmit") Cc: jeffrey.b.shaw@intel.com Cc: stable@dpdk.org Signed-off-by: Lu Qiuwen Acked-by: Xiao Wang --- drivers/net/fm10k/fm10k_rxtx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c index 5c3112183..4accaa2cd 100644 --- a/drivers/net/fm10k/fm10k_rxtx.c +++ b/drivers/net/fm10k/fm10k_rxtx.c @@ -611,6 +611,8 @@ static inline void tx_xmit_pkt(struct fm10k_tx_queue *q, struct rte_mbuf *mb) /* set vlan if requested */ if (mb->ol_flags & PKT_TX_VLAN_PKT) q->hw_ring[q->next_free].vlan = mb->vlan_tci; + else + q->hw_ring[q->next_free].vlan = 0; q->sw_ring[q->next_free] = mb; q->hw_ring[q->next_free].buffer_addr =