diff mbox series

[15/17] net/iavf/base: fix send adminq return value

Message ID	20191203070318.39620-16-qi.z.zhang@intel.com (mailing list archive)
State	Accepted, archived
Delegated to:	xiaolong ye
Headers	From: Qi Zhang <qi.z.zhang@intel.com> To: xiaolong.ye@intel.com Cc: haiyue.wang@intel.com, dev@dpdk.org, Qi Zhang <qi.z.zhang@intel.com>, Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com> Date: Tue, 3 Dec 2019 15:03:16 +0800 Message-Id: <20191203070318.39620-16-qi.z.zhang@intel.com> In-Reply-To: <20191203070318.39620-1-qi.z.zhang@intel.com> References: <20191203070318.39620-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return value Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	iavf base code update \| [00/17] iavf base code update [01/17] net/iavf/base: remove unnecessary header file [02/17] net/iavf/base: rename error code enum [03/17] net/iavf/base: rename register macro [04/17] net/iavf/base: update device id [05/17] net/iavf/base: remove unused code [06/17] net/iavf/base: remove unnecessary compile option [07/17] net/iavf/base: rename functions [08/17] net/iavf/base: update virtual channel [09/17] net/iavf/base: adjust code indent [10/17] net/iavf/base: increase max VSI count for VFs [11/17] net/iavf/base: fix command buffer memory free [12/17] net/iavf/base: update FW API version for X722 [13/17] net/iavf/base: add more link speed support [14/17] net/iavf/base: update copyright date [15/17] net/iavf/base: fix send adminq return value [16/17] net/iavf: move device state flag [17/17] net/ice/base: update version info

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Qi Zhang Dec. 3, 2019, 7:03 a.m. UTC

  When send a adminq, if get IAVF_AQ_RC_BUSY, we should return
IAVF_ERR_NOT_READY.

Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")

Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/iavf/base/iavf_adminq.c | 2 ++
 1 file changed, 2 insertions(+)

Comments

Qiming Yang Jan. 2, 2020, 2:48 a.m. UTC | #1

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Qi Zhang
> Sent: Tuesday, December 3, 2019 3:03 PM
> To: Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org; Zhang, Qi Z
> <qi.z.zhang@intel.com>; Stillwell Jr, Paul M <paul.m.stillwell.jr@intel.com>
> Subject: [dpdk-dev] [PATCH 15/17] net/iavf/base: fix send adminq return
> value
> 
> When send a adminq, if get IAVF_AQ_RC_BUSY, we should return
> IAVF_ERR_NOT_READY.
> 
> Fixes: e5b2a9e957e7 ("net/avf/base: add base code for avf PMD")
> 
Lack of CC stable

> Signed-off-by: Paul M Stillwell Jr <paul.m.stillwell.jr@intel.com>
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/iavf/base/iavf_adminq.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/net/iavf/base/iavf_adminq.c
> b/drivers/net/iavf/base/iavf_adminq.c
> index 0a5b2b281..c1668d228 100644
> --- a/drivers/net/iavf/base/iavf_adminq.c
> +++ b/drivers/net/iavf/base/iavf_adminq.c
> @@ -803,6 +803,8 @@ enum iavf_status iavf_asq_send_command(struct
> iavf_hw *hw,
>  		cmd_completed = true;
>  		if ((enum iavf_admin_queue_err)retval == IAVF_AQ_RC_OK)
>  			status = IAVF_SUCCESS;
> +		else if ((enum iavf_admin_queue_err)retval ==
> IAVF_AQ_RC_EBUSY)
> +			status = IAVF_ERR_NOT_READY;
>  		else
>  			status = IAVF_ERR_ADMIN_QUEUE_ERROR;
>  		hw->aq.asq_last_status = (enum
> iavf_admin_queue_err)retval;
> --
> 2.13.6

diff mbox series

Patch

diff --git a/drivers/net/iavf/base/iavf_adminq.c b/drivers/net/iavf/base/iavf_adminq.c
index 0a5b2b281..c1668d228 100644
--- a/drivers/net/iavf/base/iavf_adminq.c
+++ b/drivers/net/iavf/base/iavf_adminq.c
@@ -803,6 +803,8 @@  enum iavf_status iavf_asq_send_command(struct iavf_hw *hw,
 		cmd_completed = true;
 		if ((enum iavf_admin_queue_err)retval == IAVF_AQ_RC_OK)
 			status = IAVF_SUCCESS;
+		else if ((enum iavf_admin_queue_err)retval == IAVF_AQ_RC_EBUSY)
+			status = IAVF_ERR_NOT_READY;
 		else
 			status = IAVF_ERR_ADMIN_QUEUE_ERROR;
 		hw->aq.asq_last_status = (enum iavf_admin_queue_err)retval;