diff mbox series

[v2] add drop statistic for af_packet

Message ID 20191126143233.19235-1-podovinnikov@protei.ru (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] add drop statistic for af_packet |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed

Commit Message

podovinnikov Nov. 26, 2019, 2:32 p.m. UTC 
  Signed-off-by: Vadim <podovinnikov@protei.ru>
---
 drivers/net/af_packet/rte_eth_af_packet.c | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

Comments

Ferruh Yigit Nov. 26, 2019, 2:45 p.m. UTC | #1 
On 11/26/2019 2:32 PM, Vadim wrote:
> Signed-off-by: Vadim <podovinnikov@protei.ru>

Can you please provide full "Name Surname <email address>" syntax?

> ---
>  drivers/net/af_packet/rte_eth_af_packet.c | 11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
> index f5806bf42..da54f82f7 100644
> --- a/drivers/net/af_packet/rte_eth_af_packet.c
> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
> @@ -327,8 +327,10 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
>  {
>  	unsigned i, imax;
>  	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
> -	unsigned long rx_bytes_total = 0, tx_bytes_total = 0;
> +	unsigned long rx_bytes_total = 0, tx_bytes_total = 0, rx_drop = 0;
>  	const struct pmd_internals *internal = dev->data->dev_private;
> +	socklen_t sock_len = sizeof(struct tpacket_stats_v3);
> +	struct tpacket_stats_v3 st;

It seems you have missed comment from previous version, copying here:

This will work but since the PMD is implementing 'TPACKET_V2', this may be
confusing, what about using 'struct tpacket_stats'?


Can you also update the patchwork [1] when a new version sent please, to update
the status of the old one as "superseded".

[1] https://patches.dpdk.org/project/dpdk/list/
diff mbox series

Patch

diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
index f5806bf42..da54f82f7 100644
--- a/drivers/net/af_packet/rte_eth_af_packet.c
+++ b/drivers/net/af_packet/rte_eth_af_packet.c
@@ -327,8 +327,10 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 {
 	unsigned i, imax;
 	unsigned long rx_total = 0, tx_total = 0, tx_err_total = 0;
-	unsigned long rx_bytes_total = 0, tx_bytes_total = 0;
+	unsigned long rx_bytes_total = 0, tx_bytes_total = 0, rx_drop = 0;
 	const struct pmd_internals *internal = dev->data->dev_private;
+	socklen_t sock_len = sizeof(struct tpacket_stats_v3);
+	struct tpacket_stats_v3 st;
 
 	imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
 	        internal->nb_queues : RTE_ETHDEV_QUEUE_STAT_CNTRS);
@@ -337,6 +339,12 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 		igb_stats->q_ibytes[i] = internal->rx_queue[i].rx_bytes;
 		rx_total += igb_stats->q_ipackets[i];
 		rx_bytes_total += igb_stats->q_ibytes[i];
+
+		memset(&st, 0, sock_len);
+		int rc = getsockopt(internal->rx_queue[i].sockfd, SOL_PACKET,
+					PACKET_STATISTICS, &st, &sock_len);
+		if (rc == 0)
+			rx_drop += st.tp_drops;
 	}
 
 	imax = (internal->nb_queues < RTE_ETHDEV_QUEUE_STAT_CNTRS ?
@@ -349,6 +357,7 @@  eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *igb_stats)
 		tx_bytes_total += igb_stats->q_obytes[i];
 	}
 
+	igb_stats->imissed = rx_drop;
 	igb_stats->ipackets = rx_total;
 	igb_stats->ibytes = rx_bytes_total;
 	igb_stats->opackets = tx_total;