diff mbox series

[2/2] app/test-evnetdev: fix unchecked return value

Message ID 20191121192240.12326-2-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers
Series [1/2] app/test-eventdev: fix possible divide by zero |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues
ci/travis-robot success Travis build: passed

Commit Message

Pavan Nikhilesh Bhagavatula Nov. 21, 2019, 7:22 p.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Fix unchecked return values reported by coverity.

Coverity Issue: 336861
Coverity Issue: 349906
Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")
Cc: stable@dpdk.org

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test-eventdev/test_pipeline_common.c | 17 ++++++++++++++---
 1 file changed, 14 insertions(+), 3 deletions(-)

--
2.17.1

Comments

Jerin Jacob Nov. 26, 2019, 5:18 a.m. UTC | #1 
On Fri, Nov 22, 2019 at 4:23 AM <pbhagavatula@marvell.com> wrote:
>
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
>
> Fix unchecked return values reported by coverity.
>
> Coverity Issue: 336861
> Coverity Issue: 349906
> Fixes: 032a965a8f1d ("app/eventdev: support Tx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>

Changed the subject to "app/test-eventdev: fix unchecked return value"

Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-eventdev/master. Thanks.

> ---
>  app/test-eventdev/test_pipeline_common.c | 17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
> index 160461fb2..fa91bf229 100644
> --- a/app/test-eventdev/test_pipeline_common.c
> +++ b/app/test-eventdev/test_pipeline_common.c
> @@ -196,7 +196,12 @@ pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
>                 struct rte_eth_conf local_port_conf = port_conf;
>                 uint32_t caps = 0;
>
> -               rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
> +               ret = rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
> +               if (ret != 0) {
> +                       evt_err("failed to get event tx adapter[%d] caps", i);
> +                       return ret;
> +               }
> +
>                 if (!(caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT))
>                         t->internal_port = 0;
>
> @@ -424,7 +429,7 @@ int
>  pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
>  {
>         struct test_pipeline *t = evt_test_priv(test);
> -       int i;
> +       int i, ret;
>
>         if (!opt->mbuf_sz)
>                 opt->mbuf_sz = RTE_MBUF_DEFAULT_BUF_SIZE;
> @@ -437,7 +442,13 @@ pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
>                 uint16_t data_size = 0;
>
>                 memset(&dev_info, 0, sizeof(dev_info));
> -               rte_eth_dev_info_get(i, &dev_info);
> +               ret = rte_eth_dev_info_get(i, &dev_info);
> +               if (ret != 0) {
> +                       evt_err("Error during getting device (port %u) info: %s\n",
> +                               i, strerror(-ret));
> +                       return ret;
> +               }
> +
>                 if (dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&
>                                 dev_info.rx_desc_lim.nb_mtu_seg_max != 0) {
>                         data_size = opt->max_pkt_sz /
> --
> 2.17.1
>
diff mbox series

Patch

diff --git a/app/test-eventdev/test_pipeline_common.c b/app/test-eventdev/test_pipeline_common.c
index 160461fb2..fa91bf229 100644
--- a/app/test-eventdev/test_pipeline_common.c
+++ b/app/test-eventdev/test_pipeline_common.c
@@ -196,7 +196,12 @@  pipeline_ethdev_setup(struct evt_test *test, struct evt_options *opt)
 		struct rte_eth_conf local_port_conf = port_conf;
 		uint32_t caps = 0;

-		rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
+		ret = rte_event_eth_tx_adapter_caps_get(opt->dev_id, i, &caps);
+		if (ret != 0) {
+			evt_err("failed to get event tx adapter[%d] caps", i);
+			return ret;
+		}
+
 		if (!(caps & RTE_EVENT_ETH_TX_ADAPTER_CAP_INTERNAL_PORT))
 			t->internal_port = 0;

@@ -424,7 +429,7 @@  int
 pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
 {
 	struct test_pipeline *t = evt_test_priv(test);
-	int i;
+	int i, ret;

 	if (!opt->mbuf_sz)
 		opt->mbuf_sz = RTE_MBUF_DEFAULT_BUF_SIZE;
@@ -437,7 +442,13 @@  pipeline_mempool_setup(struct evt_test *test, struct evt_options *opt)
 		uint16_t data_size = 0;

 		memset(&dev_info, 0, sizeof(dev_info));
-		rte_eth_dev_info_get(i, &dev_info);
+		ret = rte_eth_dev_info_get(i, &dev_info);
+		if (ret != 0) {
+			evt_err("Error during getting device (port %u) info: %s\n",
+				i, strerror(-ret));
+			return ret;
+		}
+
 		if (dev_info.rx_desc_lim.nb_mtu_seg_max != UINT16_MAX &&
 				dev_info.rx_desc_lim.nb_mtu_seg_max != 0) {
 			data_size = opt->max_pkt_sz /