doc: update release notes for AESNI PMDs

Message ID 20191114122104.21088-1-pablo.de.lara.guarch@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series doc: update release notes for AESNI PMDs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

De Lara Guarch, Pablo Nov. 14, 2019, 12:21 p.m. UTC
  AESNI MB and AESNI GCM PMDs were updated to support
latest IPSec Multi buffer library (v0.53), and the user guide
of hose drivers were updated but not release notes.

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
---
 doc/guides/rel_notes/release_19_11.rst | 9 +++++++++
 1 file changed, 9 insertions(+)
  

Comments

Akhil Goyal Nov. 14, 2019, 1:51 p.m. UTC | #1
Hi Pablo,

> AESNI MB and AESNI GCM PMDs were updated to support
> latest IPSec Multi buffer library (v0.53), and the user guide
> of hose drivers were updated but not release notes.
> 
> Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> ---
>  doc/guides/rel_notes/release_19_11.rst | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/release_19_11.rst
> b/doc/guides/rel_notes/release_19_11.rst
> index 682c1bdf3..441c53898 100644
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -223,6 +223,15 @@ New Features
>    Support is added for all sequence number sizes for control and user plane.
>    Test application is updated for unit testing.
> 
> +* **Updated the AESNI-MB PMD.**
> +
> +  * Added support for intel-ipsec-mb version 0.53.
> +
> +* **Updated the AESNI-GCM PMD.**
> +
> +  * Added support for intel-ipsec-mb version 0.53.
> +  * Supported in-place chained mbufs on AES-GCM algorithm.
> +

Both the bullets can be combined in a single bullet.

>  * **Enabled Single Pass GCM acceleration on QAT GEN3.**
> 
>    Added support for Single Pass GCM, available on QAT GEN3 only (Intel
> --
> 2.21.0

Ideally this patch should be part of the actual patch which was adding this support. 

-Akhil
  
De Lara Guarch, Pablo Nov. 15, 2019, 11:30 a.m. UTC | #2
Hi Akhil,

> -----Original Message-----
> From: Akhil Goyal <akhil.goyal@nxp.com>
> Sent: Thursday, November 14, 2019 1:51 PM
> To: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>; Mcnamara, John
> <john.mcnamara@intel.com>; Kovacevic, Marko <marko.kovacevic@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH] doc: update release notes for AESNI PMDs
> 
> Hi Pablo,
> 
> > AESNI MB and AESNI GCM PMDs were updated to support latest IPSec Multi
> > buffer library (v0.53), and the user guide of hose drivers were
> > updated but not release notes.
> >
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
> > ---
> >  doc/guides/rel_notes/release_19_11.rst | 9 +++++++++
> >  1 file changed, 9 insertions(+)
> >
> > diff --git a/doc/guides/rel_notes/release_19_11.rst
> > b/doc/guides/rel_notes/release_19_11.rst
> > index 682c1bdf3..441c53898 100644
> > --- a/doc/guides/rel_notes/release_19_11.rst
> > +++ b/doc/guides/rel_notes/release_19_11.rst
> > @@ -223,6 +223,15 @@ New Features
> >    Support is added for all sequence number sizes for control and user plane.
> >    Test application is updated for unit testing.
> >
> > +* **Updated the AESNI-MB PMD.**
> > +
> > +  * Added support for intel-ipsec-mb version 0.53.
> > +
> > +* **Updated the AESNI-GCM PMD.**
> > +
> > +  * Added support for intel-ipsec-mb version 0.53.
> > +  * Supported in-place chained mbufs on AES-GCM algorithm.
> > +
> 
> Both the bullets can be combined in a single bullet.

This is following the same format as was done in the past.
They are different statements, resulting from different patches.
They don't really have anything in common (basically, the chained mbuf support
 is not something that was done due to the new intel-ipsec-mb version).

Therefore, I'd say the should be two bullet points.

> 
> >  * **Enabled Single Pass GCM acceleration on QAT GEN3.**
> >
> >    Added support for Single Pass GCM, available on QAT GEN3 only
> > (Intel
> > --
> > 2.21.0
> 
> Ideally this patch should be part of the actual patch which was adding this
> support.

Yes, that was my bad, I forgot to add these. Apologies for this.

Thanks,
Pablo

> 
> -Akhil
  
Akhil Goyal Nov. 18, 2019, 9:36 a.m. UTC | #3
> > >    Support is added for all sequence number sizes for control and user
> plane.
> > >    Test application is updated for unit testing.
> > >
> > > +* **Updated the AESNI-MB PMD.**
> > > +
> > > +  * Added support for intel-ipsec-mb version 0.53.
> > > +
> > > +* **Updated the AESNI-GCM PMD.**
> > > +
> > > +  * Added support for intel-ipsec-mb version 0.53.
> > > +  * Supported in-place chained mbufs on AES-GCM algorithm.
> > > +
> >
> > Both the bullets can be combined in a single bullet.
> 
> This is following the same format as was done in the past.
> They are different statements, resulting from different patches.
> They don't really have anything in common (basically, the chained mbuf
> support
>  is not something that was done due to the new intel-ipsec-mb version).
> 
> Therefore, I'd say the should be two bullet points.

Ok
> 
> >
> > >  * **Enabled Single Pass GCM acceleration on QAT GEN3.**
> > >
> > >    Added support for Single Pass GCM, available on QAT GEN3 only
> > > (Intel
> > > --
> > > 2.21.0
> >
> > Ideally this patch should be part of the actual patch which was adding this
> > support.
> 
> Yes, that was my bad, I forgot to add these. Apologies for this.

Added fix line for both the features to get a reference of the original patch.

Applied to dpdk-next-crypto

Thanks.
  

Patch

diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
index 682c1bdf3..441c53898 100644
--- a/doc/guides/rel_notes/release_19_11.rst
+++ b/doc/guides/rel_notes/release_19_11.rst
@@ -223,6 +223,15 @@  New Features
   Support is added for all sequence number sizes for control and user plane.
   Test application is updated for unit testing.
 
+* **Updated the AESNI-MB PMD.**
+
+  * Added support for intel-ipsec-mb version 0.53.
+
+* **Updated the AESNI-GCM PMD.**
+
+  * Added support for intel-ipsec-mb version 0.53.
+  * Supported in-place chained mbufs on AES-GCM algorithm.
+
 * **Enabled Single Pass GCM acceleration on QAT GEN3.**
 
   Added support for Single Pass GCM, available on QAT GEN3 only (Intel