diff mbox series

[6/9] net/ipn3ke: remove commented out code

Message ID 20191001130405.7076-5-ktraynor@redhat.com (mailing list archive)
State Superseded, archived
Delegated to: David Marchand
Headers
Series Coverity fixes and other cleanups |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Kevin Traynor Oct. 1, 2019, 1:04 p.m. UTC 
These struct members and variable were commented out. Remove them.

Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
Fixes: c820468ac99c ("net/ipn3ke: support TM")
Cc: rosen.xu@intel.com
Cc: stable@dpdk.org

Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
---
 drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
 drivers/net/ipn3ke/ipn3ke_tm.c     | 1 -
 2 files changed, 8 deletions(-)

Comments

David Marchand Oct. 30, 2019, 8:04 a.m. UTC | #1 
On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor <ktraynor@redhat.com> wrote:
>
> These struct members and variable were commented out. Remove them.
>
> Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> Fixes: c820468ac99c ("net/ipn3ke: support TM")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
>  drivers/net/ipn3ke/ipn3ke_tm.c     | 1 -
>  2 files changed, 8 deletions(-)
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> index c7b336bbd..0d71dcd64 100644
> --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> @@ -97,18 +97,11 @@ struct ipn3ke_tm_node {
>  struct ipn3ke_tm_hierarchy {
>         struct ipn3ke_tm_node *port_node;
> -       /*struct ipn3ke_tm_node_list vt_node_list;*/
> -       /*struct ipn3ke_tm_node_list cos_node_list;*/
> -
>         uint32_t n_shaper_profiles;
> -       /*uint32_t n_shared_shapers;*/
>         uint32_t n_tdrop_profiles;
>         uint32_t n_vt_nodes;
>         uint32_t n_cos_nodes;
> -
>         struct ipn3ke_tm_node *port_commit_node;
>         struct ipn3ke_tm_node_list vt_commit_node_list;
>         struct ipn3ke_tm_node_list cos_commit_node_list;
> -
> -       /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
>  };
>
> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c
> index a93145d59..5a16c5f96 100644
> --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t tm_id,
>         struct rte_tm_error *error)
>  {
> -       /*struct ipn3ke_tm_internals *tm = IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
>         uint32_t node_index;
>         uint32_t parent_index;
> --
> 2.21.0
>

Reviewed-by: David Marchand <david.marchand@redhat.com>
Xu, Rosen Nov. 8, 2019, 2:40 p.m. UTC | #2 
Hi,

Too busy these days, sorry for late reply.

> -----Original Message-----
> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Wednesday, October 30, 2019 16:04
> To: Kevin Traynor <ktraynor@redhat.com>
> Cc: dev <dev@dpdk.org>; Xu, Rosen <rosen.xu@intel.com>; dpdk stable
> <stable@dpdk.org>
> Subject: Re: [dpdk-stable] [PATCH 6/9] net/ipn3ke: remove commented out
> code
> 
> On Tue, Oct 1, 2019 at 3:04 PM Kevin Traynor <ktraynor@redhat.com> wrote:
> >
> > These struct members and variable were commented out. Remove them.
> >
> > Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> > Fixes: c820468ac99c ("net/ipn3ke: support TM")
> > Cc: rosen.xu@intel.com
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> > ---
> >  drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
> >  drivers/net/ipn3ke/ipn3ke_tm.c     | 1 -
> >  2 files changed, 8 deletions(-)
> >
> > diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> > b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> > index c7b336bbd..0d71dcd64 100644
> > --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> > +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> > @@ -97,18 +97,11 @@ struct ipn3ke_tm_node {  struct
> > ipn3ke_tm_hierarchy {
> >         struct ipn3ke_tm_node *port_node;
> > -       /*struct ipn3ke_tm_node_list vt_node_list;*/
> > -       /*struct ipn3ke_tm_node_list cos_node_list;*/
> > -
> >         uint32_t n_shaper_profiles;
> > -       /*uint32_t n_shared_shapers;*/
> >         uint32_t n_tdrop_profiles;
> >         uint32_t n_vt_nodes;
> >         uint32_t n_cos_nodes;
> > -
> >         struct ipn3ke_tm_node *port_commit_node;
> >         struct ipn3ke_tm_node_list vt_commit_node_list;
> >         struct ipn3ke_tm_node_list cos_commit_node_list;
> > -
> > -       /*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
> >  };
> >
> > diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c
> > b/drivers/net/ipn3ke/ipn3ke_tm.c index a93145d59..5a16c5f96 100644
> > --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> > +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> > @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t
> tm_id,
> >         struct rte_tm_error *error)
> >  {
> > -       /*struct ipn3ke_tm_internals *tm =
> IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
> >         uint32_t node_index;
> >         uint32_t parent_index;
> > --
> > 2.21.0
> >
> 
> Reviewed-by: David Marchand <david.marchand@redhat.com>
> 
> 
> --
> David Marchand

Reviewed-by: Rosen Xu <rosen.xu@intel.com>
Xu, Rosen Nov. 8, 2019, 2:51 p.m. UTC | #3 
Hi,

> -----Original Message-----
> From: Kevin Traynor [mailto:ktraynor@redhat.com]
> Sent: Tuesday, October 01, 2019 21:04
> To: dev@dpdk.org
> Cc: Kevin Traynor <ktraynor@redhat.com>; Xu, Rosen
> <rosen.xu@intel.com>; stable@dpdk.org
> Subject: [PATCH 6/9] net/ipn3ke: remove commented out code
> 
> These struct members and variable were commented out. Remove them.
> 
> Fixes: c01c748e4ae6 ("net/ipn3ke: add new driver")
> Fixes: c820468ac99c ("net/ipn3ke: support TM")
> Cc: rosen.xu@intel.com
> Cc: stable@dpdk.org
> 
> Signed-off-by: Kevin Traynor <ktraynor@redhat.com>
> ---
>  drivers/net/ipn3ke/ipn3ke_ethdev.h | 7 -------
>  drivers/net/ipn3ke/ipn3ke_tm.c     | 1 -
>  2 files changed, 8 deletions(-)
> 
> diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> index c7b336bbd..0d71dcd64 100644
> --- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
> +++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
> @@ -97,18 +97,11 @@ struct ipn3ke_tm_node {  struct ipn3ke_tm_hierarchy
> {
>  	struct ipn3ke_tm_node *port_node;
> -	/*struct ipn3ke_tm_node_list vt_node_list;*/
> -	/*struct ipn3ke_tm_node_list cos_node_list;*/
> -
>  	uint32_t n_shaper_profiles;
> -	/*uint32_t n_shared_shapers;*/
>  	uint32_t n_tdrop_profiles;
>  	uint32_t n_vt_nodes;
>  	uint32_t n_cos_nodes;
> -
>  	struct ipn3ke_tm_node *port_commit_node;
>  	struct ipn3ke_tm_node_list vt_commit_node_list;
>  	struct ipn3ke_tm_node_list cos_commit_node_list;
> -
> -	/*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
>  };
> 
> diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c
> b/drivers/net/ipn3ke/ipn3ke_tm.c index a93145d59..5a16c5f96 100644
> --- a/drivers/net/ipn3ke/ipn3ke_tm.c
> +++ b/drivers/net/ipn3ke/ipn3ke_tm.c
> @@ -1088,5 +1088,4 @@ ipn3ke_tm_node_add_check_mount(uint32_t
> tm_id,
>  	struct rte_tm_error *error)
>  {
> -	/*struct ipn3ke_tm_internals *tm =
> IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
>  	uint32_t node_index;
>  	uint32_t parent_index;
> --
> 2.21.0

Reviewed-by: Rosen Xu <rosen.xu@intel.com>
diff mbox series

Patch

diff --git a/drivers/net/ipn3ke/ipn3ke_ethdev.h b/drivers/net/ipn3ke/ipn3ke_ethdev.h
index c7b336bbd..0d71dcd64 100644
--- a/drivers/net/ipn3ke/ipn3ke_ethdev.h
+++ b/drivers/net/ipn3ke/ipn3ke_ethdev.h
@@ -97,18 +97,11 @@  struct ipn3ke_tm_node {
 struct ipn3ke_tm_hierarchy {
 	struct ipn3ke_tm_node *port_node;
-	/*struct ipn3ke_tm_node_list vt_node_list;*/
-	/*struct ipn3ke_tm_node_list cos_node_list;*/
-
 	uint32_t n_shaper_profiles;
-	/*uint32_t n_shared_shapers;*/
 	uint32_t n_tdrop_profiles;
 	uint32_t n_vt_nodes;
 	uint32_t n_cos_nodes;
-
 	struct ipn3ke_tm_node *port_commit_node;
 	struct ipn3ke_tm_node_list vt_commit_node_list;
 	struct ipn3ke_tm_node_list cos_commit_node_list;
-
-	/*uint32_t n_tm_nodes[IPN3KE_TM_NODE_LEVEL_MAX];*/
 };
 
diff --git a/drivers/net/ipn3ke/ipn3ke_tm.c b/drivers/net/ipn3ke/ipn3ke_tm.c
index a93145d59..5a16c5f96 100644
--- a/drivers/net/ipn3ke/ipn3ke_tm.c
+++ b/drivers/net/ipn3ke/ipn3ke_tm.c
@@ -1088,5 +1088,4 @@  ipn3ke_tm_node_add_check_mount(uint32_t tm_id,
 	struct rte_tm_error *error)
 {
-	/*struct ipn3ke_tm_internals *tm = IPN3KE_DEV_PRIVATE_TO_TM(dev);*/
 	uint32_t node_index;
 	uint32_t parent_index;