From patchwork Sun Sep 29 02:41:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yasufumi Ogawa X-Patchwork-Id: 60090 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1049D1F28; Sun, 29 Sep 2019 04:41:50 +0200 (CEST) Received: from mail-pg1-f196.google.com (mail-pg1-f196.google.com [209.85.215.196]) by dpdk.org (Postfix) with ESMTP id 983A12AB for ; Sun, 29 Sep 2019 04:41:48 +0200 (CEST) Received: by mail-pg1-f196.google.com with SMTP id i14so5399697pgt.11 for ; Sat, 28 Sep 2019 19:41:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=6iw5wME4jhDsNTeFz3MVhuLoDfhHQjoF9p4kJfyY7fE=; b=ecz7uvLmiw1fKWxU9u7FupRdLWhuJISZ3VEO125tFIRIUdjkvGtx3e1Ztyv4kLfwlA LPV1/Rbjd4AZgalUZkySJdoiVvebbDHfE/Wl3g0/6c2eTntg5UkTaAULiEFWS/tvcGjF xJSKdmxsJcWaT7TA+Gysyat+L/JeTe0I7GZnw9u0Sni572AjKMf7PMZOzIMJmXc8aoLN 4rbqKKlB8vd/K60RXxr7OCH2lspU7/SpjATHOE4I96NM9/sk1Kxot8DKDOpnbjJLdZyt 4LHGwL1KLx/hbr2d4UOeLBHX7btjafhGw4vEkdWepH+6K3+alSlu40x4P94fF/2tb4UZ Lung== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=6iw5wME4jhDsNTeFz3MVhuLoDfhHQjoF9p4kJfyY7fE=; b=Urd2+ik6I2yF7dY5ie3ahHe6UfPvcXbPomdry/f6NTswC/j1NE+TX706dYbtKo1RR2 SeV75ltrsHdeWz1+v4AQhilGVCMb2VNxUbnAMzM6rsPHYZAHZMo6dx+RdTOxqZIil+zv bia+8FJIUHbWK9Cd35mVPPGnsvtxKthTzVPIIzBaMERJK66Vbcp0TjPBlhu8PJ5EdaFj ZuMP5nREw0VV3f0VWKrB+8te8gnVfN5Oh9n1i/lS0dzDfJtekoGV9q5IcS2s8HKWYHRW qyhlx+Oum/37qE6848E7hkM8zmk1MICxewmLCS2IJDWN9u/bMkW8WUQlHQqI3mHo0BCU wOjA== X-Gm-Message-State: APjAAAVIyB2POBl4Dsm3Voz8AM3taxnqK56hH518gliEuIq8goQs0A2h FIIv8VQosEHtK60c+JaG0w8= X-Google-Smtp-Source: APXvYqxIDfWbHvnlGxpfUstsFr93KbFGANF8XgWVhk+IC1jaec+fqHTw1rrwjEq1sC/9VPBmvwsoGw== X-Received: by 2002:a63:c645:: with SMTP id x5mr17637332pgg.425.1569724907627; Sat, 28 Sep 2019 19:41:47 -0700 (PDT) Received: from localhost.localdomain ([2400:4050:c8c2:de00:95be:3968:b0c2:6ad]) by smtp.gmail.com with ESMTPSA id m12sm9069435pff.66.2019.09.28.19.41.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 28 Sep 2019 19:41:47 -0700 (PDT) From: Yasufumi Ogawa To: Tetsuya Mukawa Cc: dev@dpdk.org, Yasufumi Ogawa Date: Sun, 29 Sep 2019 11:41:41 +0900 Message-Id: <20190929024141.30443-1-yasufum.o@gmail.com> X-Mailer: git-send-email 2.17.1 Subject: [dpdk-dev] [PATCH] net/null: fix multi-process rx and tx X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Packet processing in secondary process cannot work because rx_pkt_burst and tx_pkt_burst in eth_dev are not initialized while probing device. This patch is to the initialization. Signed-off-by: Yasufumi Ogawa Reviewed-by: Ferruh Yigit --- drivers/net/null/rte_eth_null.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/null/rte_eth_null.c b/drivers/net/null/rte_eth_null.c index 0c60d241a..5a2010e3e 100644 --- a/drivers/net/null/rte_eth_null.c +++ b/drivers/net/null/rte_eth_null.c @@ -586,6 +586,13 @@ rte_pmd_null_probe(struct rte_vdev_device *dev) /* TODO: request info from primary to set up Rx and Tx */ eth_dev->dev_ops = &ops; eth_dev->device = &dev->device; + if (packet_copy) { + eth_dev->rx_pkt_burst = eth_null_copy_rx; + eth_dev->tx_pkt_burst = eth_null_copy_tx; + } else { + eth_dev->rx_pkt_burst = eth_null_rx; + eth_dev->tx_pkt_burst = eth_null_tx; + } rte_eth_dev_probing_finish(eth_dev); return 0; }