| Message ID | 20190829080000.20806-5-maxime.coquelin@redhat.com (mailing list archive) |
|---|---|
| State | Rejected, archived |
| Delegated to: | Maxime Coquelin |
| Headers | show |
| Series | Introduce Virtio vDPA driver | expand |
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | success | coding style OK |
| ci/Intel-compilation | fail | Compilation issues |
On Thu, Aug 29, 2019 at 09:59:49AM +0200, Maxime Coquelin wrote: > The Virtio PCI susbsytem IDs need to be specified to > prevent it to probe IFC vDPA VFs. > > Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> > --- > drivers/net/virtio/virtio_pci.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h > index a38cb45ad..56f89a454 100644 > --- a/drivers/net/virtio/virtio_pci.h > +++ b/drivers/net/virtio/virtio_pci.h > @@ -19,6 +19,7 @@ struct virtnet_ctl; > #define VIRTIO_PCI_VENDORID 0x1AF4 > #define VIRTIO_PCI_LEGACY_DEVICEID_NET 0x1000 > #define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 > +#define VIRTIO_PCI_SUBSY_DEVICEID_NET 0x1100 0x1100 is the subsystem device ID used by QEMU. Maybe naming it VIRTIO_PCI_SUBSYS_DEVICEID_QEMU is better? Regards, Tiwei > > /* VirtIO ABI version, this must match exactly. */ > #define VIRTIO_PCI_ABI_VERSION 0 > -- > 2.21.0 >
On 9/2/19 8:14 AM, Tiwei Bie wrote: > On Thu, Aug 29, 2019 at 09:59:49AM +0200, Maxime Coquelin wrote: >> The Virtio PCI susbsytem IDs need to be specified to >> prevent it to probe IFC vDPA VFs. >> >> Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> >> --- >> drivers/net/virtio/virtio_pci.h | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h >> index a38cb45ad..56f89a454 100644 >> --- a/drivers/net/virtio/virtio_pci.h >> +++ b/drivers/net/virtio/virtio_pci.h >> @@ -19,6 +19,7 @@ struct virtnet_ctl; >> #define VIRTIO_PCI_VENDORID 0x1AF4 >> #define VIRTIO_PCI_LEGACY_DEVICEID_NET 0x1000 >> #define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 >> +#define VIRTIO_PCI_SUBSY_DEVICEID_NET 0x1100 > > 0x1100 is the subsystem device ID used by QEMU. > Maybe naming it VIRTIO_PCI_SUBSYS_DEVICEID_QEMU is better? Indeed, will do. Thanks, Maxime > Regards, > Tiwei > >> >> /* VirtIO ABI version, this must match exactly. */ >> #define VIRTIO_PCI_ABI_VERSION 0 >> -- >> 2.21.0 >>
diff --git a/drivers/net/virtio/virtio_pci.h b/drivers/net/virtio/virtio_pci.h index a38cb45ad..56f89a454 100644 --- a/drivers/net/virtio/virtio_pci.h +++ b/drivers/net/virtio/virtio_pci.h @@ -19,6 +19,7 @@ struct virtnet_ctl; #define VIRTIO_PCI_VENDORID 0x1AF4 #define VIRTIO_PCI_LEGACY_DEVICEID_NET 0x1000 #define VIRTIO_PCI_MODERN_DEVICEID_NET 0x1041 +#define VIRTIO_PCI_SUBSY_DEVICEID_NET 0x1100 /* VirtIO ABI version, this must match exactly. */ #define VIRTIO_PCI_ABI_VERSION 0
The Virtio PCI susbsytem IDs need to be specified to prevent it to probe IFC vDPA VFs. Signed-off-by: Maxime Coquelin <maxime.coquelin@redhat.com> --- drivers/net/virtio/virtio_pci.h | 1 + 1 file changed, 1 insertion(+)