From patchwork Wed Jul 24 06:01:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Somnath Kotur X-Patchwork-Id: 56987 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 92B971C119; Wed, 24 Jul 2019 08:07:45 +0200 (CEST) Received: from relay.smtp.broadcom.com (unknown [192.19.232.149]) by dpdk.org (Postfix) with ESMTP id 2A4271C0AD for ; Wed, 24 Jul 2019 08:07:41 +0200 (CEST) Received: from dhcp-10-123-153-55.dhcp.broadcom.net (dhcp-10-123-153-55.dhcp.broadcom.net [10.123.153.55]) by relay.smtp.broadcom.com (Postfix) with ESMTP id D20141BECE6; Tue, 23 Jul 2019 23:07:38 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.10.3 relay.smtp.broadcom.com D20141BECE6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=broadcom.com; s=dkimrelay; t=1563948459; bh=NQzXrQIl+NQ0snuaP7NON7J+Qij/t/r8Ck4R0c6lpwU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=njyIR88itYclMeRfG1HlWxJ25WbZKh4yazJAn1roO5BntIHik2TbBI+h2p8Nv3J87 bbarwIQqVnk/PaBnnoOFVlIj8bicctAArJJl96q1iA4pfu28dlP+JBmwQ+vnTDnmQ0 nkWFHMqJjqGXQ6bk86GprmriJLvEcVd49BLCr7WM= From: Somnath Kotur To: dev@dpdk.org Cc: ferruh.yigit@intel.com Date: Wed, 24 Jul 2019 11:31:54 +0530 Message-Id: <20190724060158.15571-2-somnath.kotur@broadcom.com> X-Mailer: git-send-email 2.10.1.613.g2cc2e70 In-Reply-To: <20190724060158.15571-1-somnath.kotur@broadcom.com> References: <20190724060158.15571-1-somnath.kotur@broadcom.com> Subject: [dpdk-dev] [PATCH 1/5] net/bnxt: fix rxq start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Kalesh AP 1. Added couple of missing return value checks 2. Moved the log message to right place. Fixes: 14255b35153721 ("net/bnxt: fix queue start/stop operations") Signed-off-by: Kalesh AP Signed-off-by: Somnath Kotur --- drivers/net/bnxt/bnxt_ring.c | 4 ---- drivers/net/bnxt/bnxt_rxq.c | 21 ++++++++++++++------- 2 files changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ring.c b/drivers/net/bnxt/bnxt_ring.c index a9952e0..18d3a51 100644 --- a/drivers/net/bnxt/bnxt_ring.c +++ b/drivers/net/bnxt/bnxt_ring.c @@ -539,10 +539,6 @@ int bnxt_alloc_hwrm_rx_ring(struct bnxt *bp, int queue_index) bnxt_db_write(&rxr->ag_db, rxr->ag_prod); } rxq->index = queue_index; - PMD_DRV_LOG(INFO, - "queue %d, rx_deferred_start %d, state %d!\n", - queue_index, rxq->rx_deferred_start, - bp->eth_dev->data->rx_queue_state[queue_index]); err_out: return rc; diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c index e0eb890..7af0627 100644 --- a/drivers/net/bnxt/bnxt_rxq.c +++ b/drivers/net/bnxt/bnxt_rxq.c @@ -411,11 +411,10 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) return -EINVAL; } - dev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STARTED; - bnxt_free_hwrm_rx_ring(bp, rx_queue_id); - bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id); - PMD_DRV_LOG(INFO, "Rx queue started %d\n", rx_queue_id); + rc = bnxt_alloc_hwrm_rx_ring(bp, rx_queue_id); + if (rc) + return rc; if (dev_conf->rxmode.mq_mode & ETH_MQ_RX_RSS_FLAG) { vnic = rxq->vnic; @@ -433,12 +432,20 @@ int bnxt_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id) vnic, bp->grp_info[rx_queue_id].fw_grp_id); rc = bnxt_vnic_rss_configure(bp, vnic); + if (rc) + return rc; } - if (rc == 0) - rxq->rx_deferred_start = false; + dev->data->rx_queue_state[rx_queue_id] = + RTE_ETH_QUEUE_STATE_STARTED; + rxq->rx_deferred_start = false; - return rc; + PMD_DRV_LOG(INFO, + "queue %d, rx_deferred_start %d, state %d!\n", + rx_queue_id, rxq->rx_deferred_start, + bp->eth_dev->data->rx_queue_state[rx_queue_id]); + + return 0; } int bnxt_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)