diff mbox series

examples/ip_frag: fix stale content of eth info struct

Message ID 20190722114701.1001-1-marcinx.a.zapolski@intel.com (mailing list archive)
State Accepted, archived
Headers show
Series examples/ip_frag: fix stale content of eth info struct | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/intel-Performance-Testing success Performance Testing PASS
ci/mellanox-Performance-Testing success Performance Testing PASS

Commit Message

Marcin Zapolski July 22, 2019, 11:47 a.m. UTC
The eth_dev_info was used with content that was obsolete. Added update
of struct content prior to use.

Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")

Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
---
 examples/ip_fragmentation/main.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Ananyev, Konstantin July 22, 2019, 12:21 p.m. UTC | #1
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Marcin Zapolski
> Sent: Monday, July 22, 2019 12:47 PM
> To: dev@dpdk.org
> Cc: Richardson, Bruce <bruce.richardson@intel.com>; Zapolski, MarcinX A <marcinx.a.zapolski@intel.com>
> Subject: [dpdk-dev] [PATCH] examples/ip_frag: fix stale content of eth info struct
> 
> The eth_dev_info was used with content that was obsolete. Added update
> of struct content prior to use.
> 
> Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")
> 
> Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
> ---
>  examples/ip_fragmentation/main.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
> index edf87a1a1..03be0c12e 100644
> --- a/examples/ip_fragmentation/main.c
> +++ b/examples/ip_fragmentation/main.c
> @@ -987,6 +987,7 @@ main(int argc, char **argv)
>  		printf("\n");
> 
>  		/* init one TX queue per couple (lcore,port) */
> +		rte_eth_dev_info_get(portid, &dev_info);
>  		queueid = 0;
>  		for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
>  			if (rte_lcore_is_enabled(lcore_id) == 0)
> --

Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

> 2.17.1
Thomas Monjalon July 22, 2019, 5:10 p.m. UTC | #2
22/07/2019 14:21, Ananyev, Konstantin:
> From: Marcin Zapolski
> > The eth_dev_info was used with content that was obsolete. Added update
> > of struct content prior to use.
> > 
> > Fixes: 6b7780bfebe4 ("examples/ip_frag: fix use of ethdev internal device array")

Cc: stable@dpdk.org

> > 
> > Signed-off-by: Marcin Zapolski <marcinx.a.zapolski@intel.com>
> 
> Acked-by: Konstantin Ananyev <konstantin.ananyev@intel.com>

Looks like previous patch was not tested :)

Applied, thanks
diff mbox series

Patch

diff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c
index edf87a1a1..03be0c12e 100644
--- a/examples/ip_fragmentation/main.c
+++ b/examples/ip_fragmentation/main.c
@@ -987,6 +987,7 @@  main(int argc, char **argv)
 		printf("\n");
 
 		/* init one TX queue per couple (lcore,port) */
+		rte_eth_dev_info_get(portid, &dev_info);
 		queueid = 0;
 		for (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++) {
 			if (rte_lcore_is_enabled(lcore_id) == 0)