diff mbox series

net/pcap: fix single iface support

Message ID 20190716142621.26562-1-aideen.mcloughlin@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers show
Series net/pcap: fix single iface support | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation fail Compilation issues

Commit Message

A.McLoughlin July 16, 2019, 2:26 p.m. UTC
Because of the commit mentioned below the default case was changed and
this broke single_iface support. This patch adds a check to fix
single_iface support.

Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
Cc: cian.ferriter@intel.com

Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
---
 drivers/net/pcap/rte_eth_pcap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit July 16, 2019, 2:31 p.m. UTC | #1
On 7/16/2019 3:26 PM, A.McLoughlin wrote:
> Because of the commit mentioned below the default case was changed and
> this broke single_iface support. This patch adds a check to fix
> single_iface support.
> 
> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
> Cc: cian.ferriter@intel.com
> 
> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Ferruh Yigit July 16, 2019, 6:18 p.m. UTC | #2
On 7/16/2019 3:31 PM, Ferruh Yigit wrote:
> On 7/16/2019 3:26 PM, A.McLoughlin wrote:
>> Because of the commit mentioned below the default case was changed and
>> this broke single_iface support. This patch adds a check to fix
>> single_iface support.
>>
>> Fixes: a3f5252e5cbd ("net/pcap: enable infinitely Rx a pcap file")
>> Cc: cian.ferriter@intel.com
>>
>> Signed-off-by: A.McLoughlin <aideen.mcloughlin@intel.com>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 

Applied to dpdk-next-net/master, thanks.
diff mbox series

Patch

diff --git a/drivers/net/pcap/rte_eth_pcap.c b/drivers/net/pcap/rte_eth_pcap.c
index 26e85183e..941e54c76 100644
--- a/drivers/net/pcap/rte_eth_pcap.c
+++ b/drivers/net/pcap/rte_eth_pcap.c
@@ -1322,7 +1322,7 @@  eth_from_pcaps(struct rte_vdev_device *vdev,
 	/* Assign tx ops. */
 	if (devargs_all->is_tx_pcap)
 		eth_dev->tx_pkt_burst = eth_pcap_tx_dumper;
-	else if (devargs_all->is_tx_iface)
+	else if (devargs_all->is_tx_iface || single_iface)
 		eth_dev->tx_pkt_burst = eth_pcap_tx;
 	else
 		eth_dev->tx_pkt_burst = eth_tx_drop;