diff mbox series

[2/2] test/eventdev: fix producer core validity checks

Message ID 20190630175240.1126-2-pbhagavatula@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Jerin Jacob
Headers show
Series [1/2] app/eventdev: fix order test port creation | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Pavan Nikhilesh Bhagavatula June 30, 2019, 5:52 p.m. UTC
From: Pavan Nikhilesh <pbhagavatula@marvell.com>

When producer type is event timer adapter producer lcore checks are
skipped. Since, timer adapter relies on SW to arm timers producer lcore
is essential for its functionality.
Verify producer lcore validity when producer type is event timer
adapter.

Cc: stable@dpdk.org
Fixes: b01974da9f25 ("app/eventdev: add ethernet device producer option")

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 app/test-eventdev/test_perf_common.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jerin Jacob Kollanukkaran July 2, 2019, 5:29 a.m. UTC | #1
> -----Original Message-----
> From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> Sent: Sunday, June 30, 2019 11:23 PM
> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> <pbhagavatula@marvell.com>; stable@dpdk.org
> Subject: [dpdk-dev][PATCH 2/2] test/eventdev: fix producer core validity
> checks
> 
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> When producer type is event timer adapter producer lcore checks are
> skipped. Since, timer adapter relies on SW to arm timers producer lcore is
> essential for its functionality.
> Verify producer lcore validity when producer type is event timer adapter.
> 
> Cc: stable@dpdk.org
> Fixes: b01974da9f25 ("app/eventdev: add ethernet device producer option")
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>



Acked-by: Jerin Jacob <jerinj@marvell.com>


>  app/test-eventdev/test_perf_common.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/app/test-eventdev/test_perf_common.c b/app/test-
> eventdev/test_perf_common.c
> index 01f782820..2e9e83e88 100644
> --- a/app/test-eventdev/test_perf_common.c
> +++ b/app/test-eventdev/test_perf_common.c
> @@ -562,7 +562,8 @@ perf_opt_check(struct evt_options *opt, uint64_t
> nb_queues)
>  		return -1;
>  	}
> 
> -	if (opt->prod_type == EVT_PROD_TYPE_SYNT) {
> +	if (opt->prod_type == EVT_PROD_TYPE_SYNT ||
> +			opt->prod_type ==
> EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
>  		/* Validate producer lcores */
>  		if (evt_lcores_has_overlap(opt->plcores,
>  					rte_get_master_lcore())) {
> --
> 2.21.0
Jerin Jacob Kollanukkaran July 2, 2019, 2:20 p.m. UTC | #2
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Jerin Jacob Kollanukkaran
> Sent: Tuesday, July 2, 2019 10:59 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>;
> stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 2/2] test/eventdev: fix producer core validity
> checks
> 
> > -----Original Message-----
> > From: pbhagavatula@marvell.com <pbhagavatula@marvell.com>
> > Sent: Sunday, June 30, 2019 11:23 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: dev@dpdk.org; Pavan Nikhilesh Bhagavatula
> > <pbhagavatula@marvell.com>; stable@dpdk.org
> > Subject: [dpdk-dev][PATCH 2/2] test/eventdev: fix producer core
> > validity checks
> >
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > When producer type is event timer adapter producer lcore checks are
> > skipped. Since, timer adapter relies on SW to arm timers producer
> > lcore is essential for its functionality.
> > Verify producer lcore validity when producer type is event timer adapter.
> >
> > Cc: stable@dpdk.org
> > Fixes: b01974da9f25 ("app/eventdev: add ethernet device producer
> > option")
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> 
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Series applied to dpdk-next-eventdev/master. Thanks.
diff mbox series

Patch

diff --git a/app/test-eventdev/test_perf_common.c b/app/test-eventdev/test_perf_common.c
index 01f782820..2e9e83e88 100644
--- a/app/test-eventdev/test_perf_common.c
+++ b/app/test-eventdev/test_perf_common.c
@@ -562,7 +562,8 @@  perf_opt_check(struct evt_options *opt, uint64_t nb_queues)
 		return -1;
 	}
 
-	if (opt->prod_type == EVT_PROD_TYPE_SYNT) {
+	if (opt->prod_type == EVT_PROD_TYPE_SYNT ||
+			opt->prod_type == EVT_PROD_TYPE_EVENT_TIMER_ADPTR) {
 		/* Validate producer lcores */
 		if (evt_lcores_has_overlap(opt->plcores,
 					rte_get_master_lcore())) {