From patchwork Wed May 29 06:47:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 53798 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C0A691B19; Wed, 29 May 2019 08:58:35 +0200 (CEST) Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by dpdk.org (Postfix) with ESMTP id 215BFA49 for ; Wed, 29 May 2019 08:58:33 +0200 (CEST) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 89B311A0252; Wed, 29 May 2019 08:58:33 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id F1CEA1A00BE; Wed, 29 May 2019 08:58:30 +0200 (CEST) Received: from GDB1.ap.freescale.net (GDB1.ap.freescale.net [10.232.132.179]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id DA019402CB; Wed, 29 May 2019 14:58:26 +0800 (SGT) From: Shreyansh Jain To: ferruh.yigit@intel.com, stephen@networkplumber.org, bluca@debian.org Cc: dev@dpdk.org, Shreyansh Jain Date: Wed, 29 May 2019 12:17:16 +0530 Message-Id: <20190529064716.14344-1-shreyansh.jain@nxp.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH] common/dpaax: fix i686 compilation issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Meson build on i686, part of DPDK CI, reports: (example report [1]) *Meson Failed Build #1: OS: UB1604-32 Target: i686-native-linuxapp-gcc ../drivers/common/dpaax/dpaax_iova_table.c:121:3: note: in expansion of macro ‘DPAAX_DEBUG’ DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)", ^ 'statbuf.st_size', part of fstat() is a 'off_t' - which should be printable as '%lu'. But, only a particularly old compiler reports this (5.4.0). For now, removing the variable being dumped as part of debug. [1] http://mails.dpdk.org/archives/test-report/2019-May/082622.html Fixes: 2f3d633aa593 ("common/dpaax: add library for PA/VA translation table") Cc: shreyansh.jain@nxp.com Signed-off-by: Shreyansh Jain --- Note: - Another option was to use the PRIu32 macros but, in absence of a proper verification environment, I wish to take the safer route. In future, if need arises, the field would be added to debug logs. drivers/common/dpaax/dpaax_iova_table.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/common/dpaax/dpaax_iova_table.c b/drivers/common/dpaax/dpaax_iova_table.c index 2dd38a920..4ba38ac00 100644 --- a/drivers/common/dpaax/dpaax_iova_table.c +++ b/drivers/common/dpaax/dpaax_iova_table.c @@ -118,8 +118,7 @@ read_memory_node(unsigned int *count) */ *count = (statbuf.st_size / 16); if ((*count) <= 0 || (statbuf.st_size % 16 != 0)) { - DPAAX_DEBUG("Invalid memory node values or count. (size=%lu)", - statbuf.st_size); + DPAAX_DEBUG("Invalid memory node values or count. "); goto cleanup; }