From patchwork Wed Apr 10 07:29:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pavan Nikhilesh Bhagavatula X-Patchwork-Id: 52543 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 93E705F2E; Wed, 10 Apr 2019 09:29:23 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 3A22B5B36; Wed, 10 Apr 2019 09:29:21 +0200 (CEST) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x3A7PtbY003354; Wed, 10 Apr 2019 00:29:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=7o54iJLTd2geyE90fVbNi6rlFkpzJW/5Oj8HiPNbzpI=; b=lMlqijZ1tOSfkrKvlewl1CTupwVuwSDCIetIiH83IPDZwcanUDoQxCFfFAQ1PLeo/iqU YBXzUoALovNUHt+54RFwgMA4NJj6a1yn1Kk/WP7agjqxx3jvrupa3MxOiVmJ+jcQk2kG PNp65BmNQ2PsCbesClh5bR2zEm6xNA0SaiFgHSg1jjzYcqxrLN+ibLBJFVDh0JvitR0X RWw0OUOLDngO9O2PR2VLwK94hoxU1xy5H6hbwfwFpl+v0nNKIz9A2AOv+x3eZYKe6Z0T 2rRZaYPBOCVqWNGaKMKD4h2ZutTmZtu/crgk8uhsiQD+bGCWKa+ty31UA41x/KqwGXOl TQ== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 2rrn7xcr23-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 10 Apr 2019 00:29:20 -0700 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Wed, 10 Apr 2019 00:29:19 -0700 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (104.47.46.59) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Wed, 10 Apr 2019 00:29:19 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7o54iJLTd2geyE90fVbNi6rlFkpzJW/5Oj8HiPNbzpI=; b=eNMHIlqEdwhdT5Wne9Z5sqlbbMgCUiBwDbUE2Zow6UOwRR3mLUTKeNCBB9GrOABEdhXMbUwQdlOXeIuDm63cvtnAWGIxka8RN9IvKTG3UU6Pu8N63WI6HGCsyJ6dsbP/oA1K8JaplcMtb0zf30UkPB83YY9+nhxSVuVMXt6jhBA= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1880.namprd18.prod.outlook.com (10.171.255.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.13; Wed, 10 Apr 2019 07:29:16 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1792.016; Wed, 10 Apr 2019 07:29:16 +0000 From: Pavan Nikhilesh Bhagavatula To: Jerin Jacob Kollanukkaran , Marko Kovacevic , Ori Kam , Bruce Richardson , Pablo de Lara , Radu Nicolau , Akhil Goyal , Tomasz Kantecki CC: "dev@dpdk.org" , Pavan Nikhilesh Bhagavatula , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection Thread-Index: AQHU728aw1HscaSM9kmXi8tFaedXcQ== Date: Wed, 10 Apr 2019 07:29:15 +0000 Message-ID: <20190410072836.17496-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: MA1PR0101CA0041.INDPRD01.PROD.OUTLOOK.COM (2603:1096:a00:22::27) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [122.167.234.147] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a7df9330-2c5a-4290-8cdc-08d6bd863c2e x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB1880; x-ms-traffictypediagnostic: CY4PR1801MB1880: x-microsoft-antispam-prvs: x-forefront-prvs: 00032065B2 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(396003)(136003)(346002)(39860400002)(376002)(366004)(199004)(189003)(316002)(3846002)(256004)(6486002)(8936002)(476003)(66066001)(8676002)(81166006)(4326008)(81156014)(25786009)(54906003)(110136005)(50226002)(68736007)(2906002)(2616005)(1076003)(6506007)(86362001)(52116002)(7736002)(386003)(99286004)(6116002)(14444005)(478600001)(71200400001)(102836004)(14454004)(105586002)(186003)(71190400001)(106356001)(26005)(78486014)(36756003)(305945005)(486006)(53936002)(6436002)(4744005)(97736004)(5660300002)(6512007); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1880; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: tQIUic0JbZMxbUIUoiJzWhbR29OjOg+9JkQUxHCLwpLTrZFAqGpjwQkV7j07fSfO25AmhAQGIpDrC+kBveETczUF9rRCwqEJqENS7WcFy7dCAWVJk7ROcHquXp3eZt/DiEhKbbGueLjwMv4krgxSNVWWOjqtnB26zabdnr/f23RwdKg8sULC1xkSDFAMsSzeXn8UClXjvIrusZ0tkvtOwWXKpZpKlk0BSpADUMpirOw6GiwnjMfElcUJg6u/kQ63RU+MppyLnqIRxC6D2+p2VTBP77rHdNS1F+SiLtlJxjsR8sGsaeGPSz0IlYdkczW9hMxhrt8DA9lbsPCevfeCz7iJ8nQqNXNT7POVH+4Dr+3AsQrsqWF+PN5ozMNJhHRFHmKEEQa/RV/hqnwtxn19jET40yJ1AmN0lCpKEEcnAmo= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a7df9330-2c5a-4290-8cdc-08d6bd863c2e X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Apr 2019 07:29:15.9729 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1880 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-10_04:, , signatures=0 Subject: [dpdk-dev] [PATCH] examples/l3fwd: fix em mode datapath selection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Pavan Nikhilesh Currently, l3wfd em mode has two datapath modes em_sequential and em_hlm. We can select either of them by defining NO_HASH_MULTI_LOOKUP to one or zero. The code checks if NO_HASH_MULTI_LOOKUP is defined or not instead of checking for the value. Fixes: 52c97adc1f0f ("examples/l3fwd: fix exact match performance") Cc: stable@dpdk.org Signed-off-by: Pavan Nikhilesh --- examples/l3fwd/l3fwd_em.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c index fa8f82be6..3980d94b8 100644 --- a/examples/l3fwd/l3fwd_em.c +++ b/examples/l3fwd/l3fwd_em.c @@ -299,7 +299,7 @@ em_get_ipv6_dst_port(void *ipv6_hdr, uint16_t portid, void *lookup_struct) } #if defined RTE_ARCH_X86 || defined RTE_MACHINE_CPUFLAG_NEON -#if defined(NO_HASH_MULTI_LOOKUP) +#if NO_HASH_MULTI_LOOKUP #include "l3fwd_em_sequential.h" #else #include "l3fwd_em_hlm.h"