| Message ID | 20190408101236.18076-1-pbhagavatula@marvell.com (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Delegated to: | Ferruh Yigit |
| Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6440B2BD8; Mon, 8 Apr 2019 12:13:10 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 5C4152BC9 for <dev@dpdk.org>; Mon, 8 Apr 2019 12:13:08 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x38A4HA7028808; Mon, 8 Apr 2019 03:13:07 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : content-type : content-transfer-encoding : mime-version; s=pfpt0818; bh=zsKwiUhfZ0gB04zBOZlCGJQ8FHVaKwVZtmyM+UKOD48=; b=B7Ha1n1ggpwVP81FjYJdc7W5EoPMAY2MFrcIL7asj9hiuOcBTc52OVanRvAjMdty2gIf 7TkRGUCLd7W7TF2t+hbnDXfVKwr8BaMd8E4m6aBI6I2EPOPQ1U5hBguDXv69K5Q4I4tN Ibc8lnPBgIxB0UZ6FMCcDDMzE8wXMhotdeceX48bKrKlyzZBiAZ1UHTy5O6R4NFe3EId 7oDbOcY6c2M50BkE/fo/r7JhiO3Pbdrug86ciMKbv5TR1K5dZGGRL8VXQKw9Y8G9Mhsp Agojh0Aw0Z9ZdZ2UVzkIcdAiwwmBSAla/mq5WEIm2+vBer6SfebOwsqLyTLNbu38vukz Yg== Received: from sc-exch04.marvell.com ([199.233.58.184]) by mx0a-0016f401.pphosted.com with ESMTP id 2rr1wc0jf1-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 08 Apr 2019 03:13:07 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1367.3; Mon, 8 Apr 2019 03:13:06 -0700 Received: from NAM01-BN3-obe.outbound.protection.outlook.com (104.47.33.57) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1367.3 via Frontend Transport; Mon, 8 Apr 2019 03:13:05 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zsKwiUhfZ0gB04zBOZlCGJQ8FHVaKwVZtmyM+UKOD48=; b=gVOTcX44wqWvS3/FfVhrRWHxCg78fCeIGoUoBDT0cU322cq/iMN62qaXAGbiToVNmHs82WHGdp23mL4IHbaCuCLMJo6TsPLCeDbMBJR2yNduV+xMGkq/zYLQgmq/c8UBshTJBKLWIRh9o35If/19fFwp7y8OIR7wp4bQYyvrX9I= Received: from CY4PR1801MB1863.namprd18.prod.outlook.com (10.171.255.14) by CY4PR1801MB1992.namprd18.prod.outlook.com (10.171.255.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1771.21; Mon, 8 Apr 2019 10:13:04 +0000 Received: from CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d]) by CY4PR1801MB1863.namprd18.prod.outlook.com ([fe80::e980:fa09:c83a:851d%3]) with mapi id 15.20.1771.021; Mon, 8 Apr 2019 10:13:04 +0000 From: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, "thomas@monjalon.net" <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org>, Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> Thread-Topic: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation Thread-Index: AQHU7fOnwhyqrZLgQESa9clr7u/Krg== Date: Mon, 8 Apr 2019 10:13:04 +0000 Message-ID: <20190408101236.18076-1-pbhagavatula@marvell.com> Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: SGXP274CA0016.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b8::28) To CY4PR1801MB1863.namprd18.prod.outlook.com (2603:10b6:910:7a::14) x-ms-exchange-messagesentrepresentingtype: 1 x-mailer: git-send-email 2.21.0 x-originating-ip: [183.82.17.181] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e3f3b60-0d76-4fca-cf51-08d6bc0ac9ca x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600139)(711020)(4605104)(2017052603328)(7193020); SRVR:CY4PR1801MB1992; x-ms-traffictypediagnostic: CY4PR1801MB1992: x-microsoft-antispam-prvs: <CY4PR1801MB1992B1C5911DD7F4ACA97357DE2C0@CY4PR1801MB1992.namprd18.prod.outlook.com> x-forefront-prvs: 0001227049 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(346002)(366004)(396003)(39850400004)(376002)(136003)(189003)(199004)(36756003)(316002)(6436002)(14444005)(54906003)(256004)(86362001)(105586002)(106356001)(110136005)(78486014)(478600001)(2906002)(4744005)(107886003)(53936002)(66066001)(14454004)(6512007)(6116002)(3846002)(2501003)(8676002)(186003)(99286004)(5660300002)(4326008)(1076003)(305945005)(7736002)(6486002)(25786009)(8936002)(486006)(102836004)(476003)(71200400001)(71190400001)(81156014)(81166006)(52116002)(50226002)(68736007)(386003)(6506007)(2616005)(97736004)(26005); DIR:OUT; SFP:1101; SCL:1; SRVR:CY4PR1801MB1992; H:CY4PR1801MB1863.namprd18.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: marvell.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 3x9MggftIzazZJgACYzCF3oG/grcTUk6fZVbQuno/waSMDMRNb+IEHPTAQMZV219l3qu1+JgqeLhg3rl9gQvosMZrCy3fx4J8uk6XiK4WoMh6foxK5Ur/2EuWuh6zhGAJln8EoV2Qdcz8y+fD/+/atOdW8iS6fboT1nWIAOngleA8h2eJnqGW+ABoUozs+3bguYxxXOhOLsIeCHEfPPYdekJSH0Cj/SwlZAzay9Zi3Imh2HJkKHggh8h8Z1Xah8sna6IverzlUEpjyxJbkvOfVyr0NAYDE1Eyb1Fomz3YFSDCfifw8QXt6ERxhDymbTbDRBTjGo4sCfx7cX0HnblgRKwrW6iL8jx6OgdLGjRCoEYG8BB0Th+f0T0JUYn2ZTSwTc2WBFcrCgL5WR8HUarkv7BNQte5YiiWZGqAzRkGvM= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3f3b60-0d76-4fca-cf51-08d6bc0ac9ca X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Apr 2019 10:13:04.4893 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR1801MB1992 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-04-08_04:, , signatures=0 Subject: [dpdk-dev] [PATCH] app/testpmd: fix ether header size calculation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
| Series |
app/testpmd: fix ether header size calculation
|
|
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/Intel-compilation | success | Compilation OK |
| ci/intel-Performance-Testing | success | Performance Testing PASS |
| ci/mellanox-Performance-Testing | success | Performance Testing PASS |
Commit Message
Pavan Nikhilesh Bhagavatula
April 8, 2019, 10:13 a.m. UTC
From: Pavan Nikhilesh <pbhagavatula@marvell.com> Fix ether header size calculation in Tx only mode. Coverity issue: 337684 Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> --- app/test-pmd/txonly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote: > From: Pavan Nikhilesh <pbhagavatula@marvell.com> > > Fix ether header size calculation in Tx only mode. > > Coverity issue: 337684 > Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate function") > > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> > --- > app/test-pmd/txonly.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c > index 66e63788a..a9c27be3e 100644 > --- a/app/test-pmd/txonly.c > +++ b/app/test-pmd/txonly.c > @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp, > /* > * Copy headers in first packet segment(s). > */ > - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0); > + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0); Would a simpler fix not be to change "sizeof(eth_hdr)" to "sizeof(*eth_hdr)"? It would keep the logical connection between the destination and destination size, and make future refactoring easier. /Bruce
>-----Original Message----- >From: Bruce Richardson <bruce.richardson@intel.com> >Sent: Monday, April 8, 2019 5:28 PM >To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com> >Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; thomas@monjalon.net; >dev@dpdk.org >Subject: [EXT] Re: [dpdk-dev] [PATCH] app/testpmd: fix ether header size >calculation > >External Email > >---------------------------------------------------------------------- >On Mon, Apr 08, 2019 at 10:13:04AM +0000, Pavan Nikhilesh Bhagavatula wrote: >> From: Pavan Nikhilesh <pbhagavatula@marvell.com> >> >> Fix ether header size calculation in Tx only mode. >> >> Coverity issue: 337684 >> Fixes: 01b645dcff7f ("app/testpmd: move txonly prepare in separate >> function") >> >> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com> >> --- >> app/test-pmd/txonly.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index >> 66e63788a..a9c27be3e 100644 >> --- a/app/test-pmd/txonly.c >> +++ b/app/test-pmd/txonly.c >> @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct >rte_mempool *mbp, >> /* >> * Copy headers in first packet segment(s). >> */ >> - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0); >> + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0); > >Would a simpler fix not be to change "sizeof(eth_hdr)" to "sizeof(*eth_hdr)"? It >would keep the logical connection between the destination and destination size, >and make future refactoring easier. > Ack, will send v2. >/Bruce
diff --git a/app/test-pmd/txonly.c b/app/test-pmd/txonly.c index 66e63788a..a9c27be3e 100644 --- a/app/test-pmd/txonly.c +++ b/app/test-pmd/txonly.c @@ -189,7 +189,7 @@ pkt_burst_prepare(struct rte_mbuf *pkt, struct rte_mempool *mbp, /* * Copy headers in first packet segment(s). */ - copy_buf_to_pkt(eth_hdr, sizeof(eth_hdr), pkt, 0); + copy_buf_to_pkt(eth_hdr, sizeof(struct ether_hdr), pkt, 0); copy_buf_to_pkt(&pkt_ip_hdr, sizeof(pkt_ip_hdr), pkt, sizeof(struct ether_hdr)); if (txonly_multi_flow) {