Message ID | 20190404130009.22042-1-thomas@monjalon.net (mailing list archive) |
---|---|
State | Accepted, archived |
Delegated to: | Thomas Monjalon |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C448356A1; Thu, 4 Apr 2019 15:00:26 +0200 (CEST) Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by dpdk.org (Postfix) with ESMTP id CA9F5A3 for <dev@dpdk.org>; Thu, 4 Apr 2019 15:00:25 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 51F0421F40; Thu, 4 Apr 2019 09:00:25 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Apr 2019 09:00:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=mesmtp; bh=TYhGnp+/Xoraw1Rj0WlD+27 8WAOmKL/WppnLp5wa1t8=; b=pROZqyE4SdNgPyqEi8PZGkIzE85RYf0mHKqWk2z HnO71jbmRhLnhG+4A0N5oz3J3sknvmaRQA/G3tdaq/3GQ4Eq10dc0rBh5ZpAVmgF tx4KZMHWRrONyrc09gkyPcBuEI3PTfVnxggjw6p+iida94uCwMGw0C59z5b1Yoar hJBQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TYhGnp +/Xoraw1Rj0WlD+278WAOmKL/WppnLp5wa1t8=; b=XUivcrflYjmrOBuZLHSWH2 2roQxApsGyo6HlrZHZU09oXMFKskavQXy5q0qMwQKYpYTBNBTR3ECBBtZkZA4mV9 17GiboFGHbt5h7tMSCumimTFfObOZ7+YDKnE6FllsmvvnHiZPWyEnhWdKytDVoER WlYPZT98JciCyoBURwAkmdrzZzeRaNi5fcUKPOvYalYFUMhOBGUyRyBLTw+2JQ5U UxZRtBZQPHfgO3d9ICTua/A2pPA5veT4eyrU1LHyGaHMXOAITqiUPaYD27eT85xm bJB7suGwioExFwYsaCD2iWhmSfwcigQEWYRUpqLsSs7z5BU0XA2wHKFttMLPYgiQ == X-ME-Sender: <xms:6P-lXN5xuawr_9nIn3YCES71WZSFEWMOzbmS-PwpvLbReKOLqmxOMQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduuddrtdehgdehkeculddtuddrgedutddrtddtmd cutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdp uffrtefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivg hnthhsucdlqddutddtmdenucfjughrpefhvffufffkofggtgfgsehtkeertdertdejnecu hfhrohhmpefvhhhomhgrshcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlh honhdrnhgvtheqnecukfhppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehm rghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvg hrufhiiigvpedt X-ME-Proxy: <xmx:6P-lXDjuvEYHdX6x65L4M_FBicHAA5_NMnh04eRI2FcGVNLFmq6hFA> <xmx:6P-lXI6TWSLd0RrXIvblGavsGQnCgyHD3pY-fAWsgDjLICHGp5FkTQ> <xmx:6P-lXJqSbNrKiEjgUGkX4sTEMnXwBlKdbzWb1WwUZZ5jgFldKjx6mA> <xmx:6f-lXNXC9eKTW3l3eMaBNdcQRGv_5mZIgFiS-sQNZYl4DyPLjo9qAw> Received: from xps.monjalon.net (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F13210394; Thu, 4 Apr 2019 09:00:23 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: gage.eads@intel.com, Bruce Richardson <bruce.richardson@intel.com>, Konstantin Ananyev <konstantin.ananyev@intel.com> Cc: dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com> Date: Thu, 4 Apr 2019 15:00:09 +0200 Message-Id: <20190404130009.22042-1-thomas@monjalon.net> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH] eal/x86: fix pedantic build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
eal/x86: fix pedantic build
|
|
Checks
Context | Check | Description |
---|---|---|
ci/checkpatch | success | coding style OK |
ci/Intel-compilation | success | Compilation OK |
Commit Message
Thomas Monjalon
April 4, 2019, 1 p.m. UTC
When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG,
the compiler complains about non standard 128-bit integer type:
include/rte_atomic_64.h:223:3: error:
ISO C does not support ‘__int128’ types [-Werror=pedantic]
It must be marked as an extension of the standard C language
to be accepted in pedantic compilation.
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
lib/librte_eal/common/include/arch/x86/rte_atomic_64.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
04/04/2019 15:00, Thomas Monjalon: > When enabling pedantic compilation with CONFIG_RTE_LIBRTE_MLX5_DEBUG, > the compiler complains about non standard 128-bit integer type: > > include/rte_atomic_64.h:223:3: error: > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > It must be marked as an extension of the standard C language > to be accepted in pedantic compilation. > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> Forgot one line: Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange") Note: It seems only Ferruh can reproduce it. I wonder whether the RTE_STD_C11 of the union is hiding the issue.
> 04/04/2019 15:00, Thomas Monjalon: > > When enabling pedantic compilation with > CONFIG_RTE_LIBRTE_MLX5_DEBUG, > > the compiler complains about non standard 128-bit integer type: > > > > include/rte_atomic_64.h:223:3: error: > > ISO C does not support ‘__int128’ types [-Werror=pedantic] > > > > It must be marked as an extension of the standard C language to be > > accepted in pedantic compilation. > > > > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com> > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > > Forgot one line: > > Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange") > > Note: It seems only Ferruh can reproduce it. > I wonder whether the RTE_STD_C11 of the union is hiding the issue. > > With that change: Acked-by: Gage Eads <gage.eads@intel.com>
On 4/4/2019 3:14 PM, Eads, Gage wrote: > >> 04/04/2019 15:00, Thomas Monjalon: >>> When enabling pedantic compilation with >> CONFIG_RTE_LIBRTE_MLX5_DEBUG, >>> the compiler complains about non standard 128-bit integer type: >>> >>> include/rte_atomic_64.h:223:3: error: >>> ISO C does not support ‘__int128’ types [-Werror=pedantic] >>> >>> It must be marked as an extension of the standard C language to be >>> accepted in pedantic compilation. >>> >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com> >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> >> >> Forgot one line: >> >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange") >> >> Note: It seems only Ferruh can reproduce it. >> I wonder whether the RTE_STD_C11 of the union is hiding the issue. >> >> > > With that change: > Acked-by: Gage Eads <gage.eads@intel.com> > I confirm it fixes the build issue: Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
04/04/2019 17:13, Ferruh Yigit: > On 4/4/2019 3:14 PM, Eads, Gage wrote: > >> 04/04/2019 15:00, Thomas Monjalon: > >>> When enabling pedantic compilation with > >> CONFIG_RTE_LIBRTE_MLX5_DEBUG, > >>> the compiler complains about non standard 128-bit integer type: > >>> > >>> include/rte_atomic_64.h:223:3: error: > >>> ISO C does not support ‘__int128’ types [-Werror=pedantic] > >>> > >>> It must be marked as an extension of the standard C language to be > >>> accepted in pedantic compilation. > >>> > >>> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com> > >>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > >> > >> Forgot one line: > >> > >> Fixes: 640c5f09ef2c ("eal/x86: add 128-bit atomic compare exchange") > >> > >> Note: It seems only Ferruh can reproduce it. > >> I wonder whether the RTE_STD_C11 of the union is hiding the issue. > > > > With that change: > > Acked-by: Gage Eads <gage.eads@intel.com> > > > > I confirm it fixes the build issue: > > Tested-by: Ferruh Yigit <ferruh.yigit@intel.com> Applied, thanks
diff --git a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h index 4b8315926..6232c57d9 100644 --- a/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h +++ b/lib/librte_eal/common/include/arch/x86/rte_atomic_64.h @@ -220,7 +220,7 @@ typedef struct { RTE_STD_C11 union { uint64_t val[2]; - __int128 int128; + __extension__ __int128 int128; }; } __rte_aligned(16) rte_int128_t;