From patchwork Wed Apr 3 14:23:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shreyansh Jain X-Patchwork-Id: 52195 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 730461B3E0; Wed, 3 Apr 2019 16:23:48 +0200 (CEST) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (mail-eopbgr80077.outbound.protection.outlook.com [40.107.8.77]) by dpdk.org (Postfix) with ESMTP id 91D481B2AF for ; Wed, 3 Apr 2019 16:23:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Yn0ITHROfsc88hQP8l9AYrVHxcRtpAJPeGnk/zlMyGw=; b=Y6wq9BuNRWkes6iS8Uoh5v7GzTqU1Fkwc8J3s+E6c33jpYyNDeE1QBoLp3c1R4p1h6g7mMZzYXlIU36VrBu9grXGV6/t0DY1629shEcNEhS3XUKSJfoMKlI5gxbYbYztszhiLL1Qu95OyTW2AR1E8Yljo7/NMC9kxcd0YgCNVqk= Received: from VI1PR04MB4688.eurprd04.prod.outlook.com (20.177.56.80) by VI1PR04MB4960.eurprd04.prod.outlook.com (20.177.49.213) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1750.19; Wed, 3 Apr 2019 14:23:42 +0000 Received: from VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30]) by VI1PR04MB4688.eurprd04.prod.outlook.com ([fe80::f198:d57:e38d:30%4]) with mapi id 15.20.1750.017; Wed, 3 Apr 2019 14:23:42 +0000 From: Shreyansh Jain To: "ferruh.yigit@intel.com" CC: "dev@dpdk.org" , Shreyansh Jain Thread-Topic: [PATCH 1/3] bus/fslmc: cleanup unused firmware code Thread-Index: AQHU6ijWe5u8ZWRvxUyPqHOdbPKi/A== Date: Wed, 3 Apr 2019 14:23:41 +0000 Message-ID: <20190403142357.17700-2-shreyansh.jain@nxp.com> References: <20190403142357.17700-1-shreyansh.jain@nxp.com> In-Reply-To: <20190403142357.17700-1-shreyansh.jain@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [92.120.0.8] x-mailer: git-send-email 2.19.1 x-clientproxiedby: BM1PR01CA0155.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:68::25) To VI1PR04MB4688.eurprd04.prod.outlook.com (2603:10a6:803:71::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=shreyansh.jain@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 57e82f5f-32b1-429e-048f-08d6b83ff8b6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(5600139)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7193020); SRVR:VI1PR04MB4960; x-ms-traffictypediagnostic: VI1PR04MB4960: x-microsoft-antispam-prvs: x-forefront-prvs: 0996D1900D x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(366004)(396003)(136003)(346002)(39860400002)(376002)(189003)(199004)(81156014)(14454004)(6486002)(8676002)(478600001)(5640700003)(53936002)(2616005)(6916009)(66066001)(446003)(316002)(11346002)(36756003)(2351001)(81166006)(2501003)(1076003)(6512007)(71200400001)(68736007)(71190400001)(476003)(44832011)(256004)(86362001)(6506007)(5660300002)(76176011)(54906003)(486006)(26005)(6436002)(14444005)(8936002)(386003)(186003)(52116002)(50226002)(25786009)(2906002)(106356001)(97736004)(6116002)(305945005)(105586002)(99286004)(4326008)(3846002)(7736002)(102836004); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR04MB4960; H:VI1PR04MB4688.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: xoJFWP8+yZjtTvDgxP6zs4V/mUTVfT5kYT70By5ezla0RO3NmKgntvF2Onqg0s9TLMoGQTiFRZP4t8yoddKto+iiE+4mqNGvhbpGnyL6ONGr3Ut0KnD7nrurnOyQh+BXoT5JbohFBhEZQuC8FQq/XxnN9LiPIMQ0fsEfEUa9SXcqFDc6yqu+3ozRWOi5ur2cq5nAKi2UIhGdT98YZcHR9E9lswQeg0E6/3zzf/JukgxZctMeNmEo1qAcwS4b+tJS8o/pLp9ioFTB6vZBPry7m2HFdZjP9u2UCXsLmV3UljlBWpD0OVEcg1XkvHVW3SnQYoFE1x4Bqrd2t2Ff9RWnyhSX+I7mfMi2sqVROwtFJw3K7ox+TCEKTRmjCgzAGkQMOgzlfonizPej8NTUrb0CUVAvUMxfss7x2DsH3niCKIM= MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 57e82f5f-32b1-429e-048f-08d6b83ff8b6 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Apr 2019 14:23:41.9025 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4960 Subject: [dpdk-dev] [PATCH 1/3] bus/fslmc: cleanup unused firmware code X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Removes some unused firmware code which was added in last bump of the firmware version. No current features uses these APIs. Signed-off-by: Shreyansh Jain --- drivers/bus/fslmc/mc/dpci.c | 75 -------------------------------- drivers/bus/fslmc/mc/dpcon.c | 30 ------------- drivers/bus/fslmc/mc/fsl_dpci.h | 21 --------- drivers/bus/fslmc/mc/fsl_dpcon.h | 19 -------- 4 files changed, 145 deletions(-) diff --git a/drivers/bus/fslmc/mc/dpci.c b/drivers/bus/fslmc/mc/dpci.c index 95edae9d9..2874a6196 100644 --- a/drivers/bus/fslmc/mc/dpci.c +++ b/drivers/bus/fslmc/mc/dpci.c @@ -301,81 +301,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, return 0; } -/** - * dpci_get_peer_attributes() - Retrieve peer DPCI attributes. - * @mc_io: Pointer to MC portal's I/O object - * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' - * @token: Token of DPCI object - * @attr: Returned peer attributes - * - * Return: '0' on Success; Error code otherwise. - */ -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - struct dpci_peer_attr *attr) -{ - struct dpci_rsp_get_peer_attr *rsp_params; - struct mc_command cmd = { 0 }; - int err; - - /* prepare command */ - cmd.header = mc_encode_cmd_header(DPCI_CMDID_GET_PEER_ATTR, - cmd_flags, - token); - - /* send command to mc*/ - err = mc_send_command(mc_io, &cmd); - if (err) - return err; - - /* retrieve response parameters */ - rsp_params = (struct dpci_rsp_get_peer_attr *)cmd.params; - attr->peer_id = le32_to_cpu(rsp_params->id); - attr->num_of_priorities = rsp_params->num_of_priorities; - - return 0; -} - -/** - * dpci_get_link_state() - Retrieve the DPCI link state. - * @mc_io: Pointer to MC portal's I/O object - * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' - * @token: Token of DPCI object - * @up: Returned link state; returns '1' if link is up, '0' otherwise - * - * DPCI can be connected to another DPCI, together they - * create a 'link'. In order to use the DPCI Tx and Rx queues, - * both objects must be enabled. - * - * Return: '0' on Success; Error code otherwise. - */ -int dpci_get_link_state(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - int *up) -{ - struct dpci_rsp_get_link_state *rsp_params; - struct mc_command cmd = { 0 }; - int err; - - /* prepare command */ - cmd.header = mc_encode_cmd_header(DPCI_CMDID_GET_LINK_STATE, - cmd_flags, - token); - - /* send command to mc*/ - err = mc_send_command(mc_io, &cmd); - if (err) - return err; - - /* retrieve response parameters */ - rsp_params = (struct dpci_rsp_get_link_state *)cmd.params; - *up = dpci_get_field(rsp_params->up, UP); - - return 0; -} - /** * dpci_set_rx_queue() - Set Rx queue configuration * @mc_io: Pointer to MC portal's I/O object diff --git a/drivers/bus/fslmc/mc/dpcon.c b/drivers/bus/fslmc/mc/dpcon.c index 92bd26512..3f6e04b97 100644 --- a/drivers/bus/fslmc/mc/dpcon.c +++ b/drivers/bus/fslmc/mc/dpcon.c @@ -295,36 +295,6 @@ int dpcon_get_attributes(struct fsl_mc_io *mc_io, return 0; } -/** - * dpcon_set_notification() - Set DPCON notification destination - * @mc_io: Pointer to MC portal's I/O object - * @cmd_flags: Command flags; one or more of 'MC_CMD_FLAG_' - * @token: Token of DPCON object - * @cfg: Notification parameters - * - * Return: '0' on Success; Error code otherwise - */ -int dpcon_set_notification(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - struct dpcon_notification_cfg *cfg) -{ - struct dpcon_cmd_set_notification *dpcon_cmd; - struct mc_command cmd = { 0 }; - - /* prepare command */ - cmd.header = mc_encode_cmd_header(DPCON_CMDID_SET_NOTIFICATION, - cmd_flags, - token); - dpcon_cmd = (struct dpcon_cmd_set_notification *)cmd.params; - dpcon_cmd->dpio_id = cpu_to_le32(cfg->dpio_id); - dpcon_cmd->priority = cfg->priority; - dpcon_cmd->user_ctx = cpu_to_le64(cfg->user_ctx); - - /* send command to mc*/ - return mc_send_command(mc_io, &cmd); -} - /** * dpcon_get_api_version - Get Data Path Concentrator API version * @mc_io: Pointer to MC portal's DPCON object diff --git a/drivers/bus/fslmc/mc/fsl_dpci.h b/drivers/bus/fslmc/mc/fsl_dpci.h index 9af9097e5..cf3d15267 100644 --- a/drivers/bus/fslmc/mc/fsl_dpci.h +++ b/drivers/bus/fslmc/mc/fsl_dpci.h @@ -108,27 +108,6 @@ int dpci_get_attributes(struct fsl_mc_io *mc_io, uint16_t token, struct dpci_attr *attr); -/** - * struct dpci_peer_attr - Structure representing the peer DPCI attributes - * @peer_id: DPCI peer id; if no peer is connected returns (-1) - * @num_of_priorities: The pper's number of receive priorities; determines the - * number of transmit priorities for the local DPCI object - */ -struct dpci_peer_attr { - int peer_id; - uint8_t num_of_priorities; -}; - -int dpci_get_peer_attributes(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - struct dpci_peer_attr *attr); - -int dpci_get_link_state(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - int *up); - /** * enum dpci_dest - DPCI destination types * @DPCI_DEST_NONE: Unassigned destination; The queue is set in parked mode diff --git a/drivers/bus/fslmc/mc/fsl_dpcon.h b/drivers/bus/fslmc/mc/fsl_dpcon.h index fc0430dc1..36dd5f3c1 100644 --- a/drivers/bus/fslmc/mc/fsl_dpcon.h +++ b/drivers/bus/fslmc/mc/fsl_dpcon.h @@ -81,25 +81,6 @@ int dpcon_get_attributes(struct fsl_mc_io *mc_io, uint16_t token, struct dpcon_attr *attr); -/** - * struct dpcon_notification_cfg - Structure representing notification params - * @dpio_id: DPIO object ID; must be configured with a notification channel; - * to disable notifications set it to 'DPCON_INVALID_DPIO_ID'; - * @priority: Priority selection within the DPIO channel; valid values - * are 0-7, depending on the number of priorities in that channel - * @user_ctx: User context value provided with each CDAN message - */ -struct dpcon_notification_cfg { - int dpio_id; - uint8_t priority; - uint64_t user_ctx; -}; - -int dpcon_set_notification(struct fsl_mc_io *mc_io, - uint32_t cmd_flags, - uint16_t token, - struct dpcon_notification_cfg *cfg); - int dpcon_get_api_version(struct fsl_mc_io *mc_io, uint32_t cmd_flags, uint16_t *major_ver,