diff mbox series

openssl: fix bad reference of modinv

Message ID 20190205091319.11776-1-arkadiuszx.kusztal@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers
Series openssl: fix bad reference of modinv |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Arkadiusz Kusztal Feb. 5, 2019, 9:13 a.m. UTC 
  Fixes bad reference of modinv struct in openssl pmd

Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")

Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
---
 drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Fiona Trahe Feb. 5, 2019, 4:54 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Arek Kusztal
> Sent: Tuesday, February 5, 2019 9:13 AM
> To: dev@dpdk.org
> Cc: sunila.sahu@caviumnetworks.com; akhil.goyal@nxp.com; shally.verma@caviumnetworks.com;
> ashish.gupta@caviumnetworks.com; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Subject: [dpdk-dev] [PATCH] openssl: fix bad reference of modinv
> 
> Fixes bad reference of modinv struct in openssl pmd
> 
> Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
> 
> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
Also cc'ed stable@dpdk.org
Shally Verma Feb. 6, 2019, 5:11 a.m. UTC | #2 
>-----Original Message-----
>From: dev <dev-bounces@dpdk.org> On Behalf Of Arek Kusztal
>Sent: 05 February 2019 14:43
>To: dev@dpdk.org
>Cc: sunila.sahu@caviumnetworks.com; akhil.goyal@nxp.com; shally.verma@caviumnetworks.com;
>ashish.gupta@caviumnetworks.com; Arek Kusztal <arkadiuszx.kusztal@intel.com>
>Subject: [EXT] [dpdk-dev] [PATCH] openssl: fix bad reference of modinv
>
>External Email
>
>----------------------------------------------------------------------
>Fixes bad reference of modinv struct in openssl pmd
>
>Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
>
>Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
>---
> drivers/crypto/openssl/rte_openssl_pmd.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
Acked-by: Shally Verma <shally.verma@marvell.com>

Thanks
Shally
Akhil Goyal March 6, 2019, 4:41 p.m. UTC | #3 
On 2/5/2019 10:24 PM, Trahe, Fiona wrote:
>
>> -----Original Message-----
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Arek Kusztal
>> Sent: Tuesday, February 5, 2019 9:13 AM
>> To: dev@dpdk.org
>> Cc: sunila.sahu@caviumnetworks.com; akhil.goyal@nxp.com; shally.verma@caviumnetworks.com;
>> ashish.gupta@caviumnetworks.com; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
>> Subject: [dpdk-dev] [PATCH] openssl: fix bad reference of modinv
>>
>> Fixes bad reference of modinv struct in openssl pmd
>>
>> Fixes: 3e9d6bd447fb ("crypto/openssl: add RSA and mod asym operations")
>>
>> Signed-off-by: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Acked-by: Fiona Trahe <fiona.trahe@intel.com>
> Also cc'ed stable@dpdk.org
>
Acked-by: Akhil Goyal <akhil.goyal@nxp.com>

Applied to dpdk-next-crypto

Thanks.
diff mbox series

Patch

diff --git a/drivers/crypto/openssl/rte_openssl_pmd.c b/drivers/crypto/openssl/rte_openssl_pmd.c
index ea5aac6..0230050 100644
--- a/drivers/crypto/openssl/rte_openssl_pmd.c
+++ b/drivers/crypto/openssl/rte_openssl_pmd.c
@@ -1814,12 +1814,12 @@  process_openssl_modexp_op(struct rte_crypto_op *cop,
 		return -1;
 	}
 
-	base = BN_bin2bn((const unsigned char *)op->modinv.base.data,
-			op->modinv.base.length, base);
+	base = BN_bin2bn((const unsigned char *)op->modex.base.data,
+			op->modex.base.length, base);
 
 	if (BN_mod_exp(res, base, sess->u.e.exp,
 				sess->u.e.mod, sess->u.e.ctx)) {
-		op->modinv.base.length = BN_bn2bin(res, op->modinv.base.data);
+		op->modex.base.length = BN_bn2bin(res, op->modex.base.data);
 		cop->status = RTE_CRYPTO_OP_STATUS_SUCCESS;
 	} else {
 		cop->status = RTE_CRYPTO_OP_STATUS_ERROR;