[v4,3/3] doc: add deprecation marker usage
Checks
Commit Message
Define '__rte_deprecated' usage process.
Suggests keeping old API with '__rte_deprecated' marker including
next LTS, they will be removed just after the LTS release.
Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
Acked-by: Luca Boccassi <bluca@debian.org>
Acked-by: Neil Horman <nhorman@tuxdriver.com>
---
Cc: Luca Boccassi <bluca@debian.org>
Cc: Kevin Traynor <ktraynor@redhat.com>
Cc: Yongseok Koh <yskoh@mellanox.com>
Cc: Neil Horman <nhorman@tuxdriver.com>
v2:
* Rephrased as commented
v3:
* changed when to remove the deprecated API. It is now just after
an LTS release, the motivation is to keep changes small in LTS.
Based on techboard discussion:
http://mails.dpdk.org/archives/dev/2019-January/123519.html
v4:
change working around 'active':
s/active/non-experimental/
s/become active/be able to replace old API
---
doc/guides/contributing/versioning.rst | 9 +++++++++
1 file changed, 9 insertions(+)
Comments
24/01/2019 19:10, Ferruh Yigit:
> Define '__rte_deprecated' usage process.
>
> Suggests keeping old API with '__rte_deprecated' marker including
> next LTS, they will be removed just after the LTS release.
>
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Luca Boccassi <bluca@debian.org>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>
[...]
> +New API replacing previous one
> +~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> +
> +If a new API proposed functionally replaces an existing one, when the new API
> +becomes non-experimental then the old one is marked with ``__rte_deprecated``.
> +Deprecated APIs removed completely just after the next LTS.
APIs removed -> APIs are removed
> +
> +Reminder that new API should follow deprecation process to be able to replace old API.
This last sentence is not clear to me.
I think you mean the old API should follow deprecation process
to be removed (replaced).
On 1/31/2019 5:17 PM, Thomas Monjalon wrote:
>> +
>> +Reminder that new API should follow deprecation process to be able to replace old API.
> This last sentence is not clear to me.
> I think you mean the old API should follow deprecation process
> to be removed (replaced).
Yes, we are trying to say same thing.
Deprecation process required for replacing API.
01/02/2019 18:06, Ferruh Yigit:
> On 1/31/2019 5:17 PM, Thomas Monjalon wrote:
> >> +
> >> +Reminder that new API should follow deprecation process to be able to replace old API.
> > This last sentence is not clear to me.
> > I think you mean the old API should follow deprecation process
> > to be removed (replaced).
>
> Yes, we are trying to say same thing.
>
> Deprecation process required for replacing API.
I think it is important to emphasize that the process applies to removal.
@@ -125,6 +125,15 @@ added to the Release Notes:
these changes. Binaries using this library built prior to version 2.1 will
require updating and recompilation.
+New API replacing previous one
+~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+
+If a new API proposed functionally replaces an existing one, when the new API
+becomes non-experimental then the old one is marked with ``__rte_deprecated``.
+Deprecated APIs removed completely just after the next LTS.
+
+Reminder that new API should follow deprecation process to be able to replace old API.
+
Experimental APIs
-----------------