diff mbox series

baseband/turbo_sw: dynamic linking error with turbo SW

Message ID 20181203134811.10616-1-kamilx.chalupnik@intel.com (mailing list archive)
State Accepted, archived
Delegated to: akhil goyal
Headers show
Series baseband/turbo_sw: dynamic linking error with turbo SW | expand

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Kamil Chalupnik Dec. 3, 2018, 1:48 p.m. UTC
Building Turbo Software as shared library for AVX512 failed
due to wrong order of library in the library list (LDLIBS)

Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
Cc: amr.mokhtar@intel.com

Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
---
 drivers/baseband/turbo_sw/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Mokhtar, Amr Dec. 3, 2018, 6:15 p.m. UTC | #1
+ Akhil

> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Monday 3 December 2018 13:48
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Chalupnik, KamilX <kamilx.chalupnik@intel.com>
> Subject: [PATCH] baseband/turbo_sw: dynamic linking error with turbo SW
> 
> Building Turbo Software as shared library for AVX512 failed
> due to wrong order of library in the library list (LDLIBS)
> 
> Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
> Cc: amr.mokhtar@intel.com
> 
> Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
> ---
>  drivers/baseband/turbo_sw/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/baseband/turbo_sw/Makefile
> b/drivers/baseband/turbo_sw/Makefile
> index 79eb554..d364677 100644
> --- a/drivers/baseband/turbo_sw/Makefile
> +++ b/drivers/baseband/turbo_sw/Makefile
> @@ -27,8 +27,8 @@ CFLAGS += -I$(FLEXRAN_SDK)/lib_turbo
>  CFLAGS += -I$(FLEXRAN_SDK)/lib_crc
>  CFLAGS += -I$(FLEXRAN_SDK)/lib_rate_matching
> 
> -LDLIBS += -L$(FLEXRAN_SDK)/lib_crc -lcrc
>  LDLIBS += -L$(FLEXRAN_SDK)/lib_turbo -lturbo
> +LDLIBS += -L$(FLEXRAN_SDK)/lib_crc -lcrc
>  LDLIBS += -L$(FLEXRAN_SDK)/lib_rate_matching -lrate_matching
>  LDLIBS += -L$(FLEXRAN_SDK)/lib_common -lcommon
>  LDLIBS += -lstdc++ -lirc -limf -lipps
> --
> 1.8.3.1
Mokhtar, Amr Dec. 3, 2018, 6:20 p.m. UTC | #2
> -----Original Message-----
> From: Chalupnik, KamilX
> Sent: Monday 3 December 2018 13:48
> To: dev@dpdk.org
> Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo
> <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> Chalupnik, KamilX <kamilx.chalupnik@intel.com>
> Subject: [PATCH] baseband/turbo_sw: dynamic linking error with turbo SW
> 
> Building Turbo Software as shared library for AVX512 failed
> due to wrong order of library in the library list (LDLIBS)
> 
> Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
> Cc: amr.mokhtar@intel.com
> 
> Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
> ---

Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>
Akhil Goyal Dec. 18, 2018, 10:23 a.m. UTC | #3
On 12/3/2018 11:50 PM, Mokhtar, Amr wrote:
>> -----Original Message-----
>> From: Chalupnik, KamilX
>> Sent: Monday 3 December 2018 13:48
>> To: dev@dpdk.org
>> Cc: Mokhtar, Amr <amr.mokhtar@intel.com>; De Lara Guarch, Pablo
>> <pablo.de.lara.guarch@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
>> Chalupnik, KamilX <kamilx.chalupnik@intel.com>
>> Subject: [PATCH] baseband/turbo_sw: dynamic linking error with turbo SW
>>
>> Building Turbo Software as shared library for AVX512 failed
>> due to wrong order of library in the library list (LDLIBS)
>>
>> Fixes: b8cfe2c9aed2 ("bb/turbo_sw: add software turbo driver")
>> Cc: amr.mokhtar@intel.com
>>
>> Signed-off-by: Kamil Chalupnik <kamilx.chalupnik@intel.com>
>> ---
> Acked-by: Amr Mokhtar <amr.mokhtar@intel.com>
Applied to dpdk-next-crypto

Thanks
diff mbox series

Patch

diff --git a/drivers/baseband/turbo_sw/Makefile b/drivers/baseband/turbo_sw/Makefile
index 79eb554..d364677 100644
--- a/drivers/baseband/turbo_sw/Makefile
+++ b/drivers/baseband/turbo_sw/Makefile
@@ -27,8 +27,8 @@  CFLAGS += -I$(FLEXRAN_SDK)/lib_turbo
 CFLAGS += -I$(FLEXRAN_SDK)/lib_crc
 CFLAGS += -I$(FLEXRAN_SDK)/lib_rate_matching
 
-LDLIBS += -L$(FLEXRAN_SDK)/lib_crc -lcrc
 LDLIBS += -L$(FLEXRAN_SDK)/lib_turbo -lturbo
+LDLIBS += -L$(FLEXRAN_SDK)/lib_crc -lcrc
 LDLIBS += -L$(FLEXRAN_SDK)/lib_rate_matching -lrate_matching
 LDLIBS += -L$(FLEXRAN_SDK)/lib_common -lcommon
 LDLIBS += -lstdc++ -lirc -limf -lipps