diff mbox series

doc: fix a typo in testpmd guide

Message ID 20181201061437.4355-1-ramirose@gmail.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series doc: fix a typo in testpmd guide |

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/mellanox-Performance-Testing success Performance Testing PASS
ci/intel-Performance-Testing success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Rami Rosen Dec. 1, 2018, 6:14 a.m. UTC 
  This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)

Signed-off-by: Rami Rosen <ramirose@gmail.com>
---
 doc/guides/testpmd_app_ug/testpmd_funcs.rst | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Iremonger, Bernard Dec. 2, 2018, 5:44 p.m. UTC | #1 
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> Sent: Saturday, December 1, 2018 6:15 AM
> To: dev@dpdk.org
> Cc: stable@dpdk.org; Rami Rosen <ramirose@gmail.com>
> Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide
> 
> This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)
> 
> Signed-off-by: Rami Rosen <ramirose@gmail.com>

Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>
Iremonger, Bernard Dec. 3, 2018, 5:22 p.m. UTC | #2 
Hi Rami

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Iremonger, Bernard
> Sent: Sunday, December 2, 2018 5:44 PM
> To: Rami Rosen <ramirose@gmail.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide
> 
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Rami Rosen
> > Sent: Saturday, December 1, 2018 6:15 AM
> > To: dev@dpdk.org
> > Cc: stable@dpdk.org; Rami Rosen <ramirose@gmail.com>
> > Subject: [dpdk-dev] [PATCH] doc: fix a typo in testpmd guide
> >
> > This patch fixes a typo in testpmd guide (should be ICMP and not IMCP)
> >
> > Signed-off-by: Rami Rosen <ramirose@gmail.com>
> 
> Acked-by: Bernard Iremonger <bernard.iremonger@intel.com>

I forgot to run ./dpdk/devtools/check-git-log.sh -1

Missing 'Fixes' tag:
        doc: fix a typo in testpmd guide

Could you send a V2 with the fixes line and carry forward my ack.

Regards,

Bernard.
diff mbox series

Patch

diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
index 056f8bb32..63e4a2d19 100644
--- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst
+++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst
@@ -318,7 +318,7 @@  The available information categories are:
 
 * ``csum``: Changes the checksum field with hardware or software methods depending on the offload flags on the packet.
 
-* ``icmpecho``: Receives a burst of packets, lookup for IMCP echo requests and, if any, send back ICMP echo replies.
+* ``icmpecho``: Receives a burst of packets, lookup for ICMP echo requests and, if any, send back ICMP echo replies.
 
 * ``ieee1588``: Demonstrate L2 IEEE1588 V2 PTP timestamping for RX and TX. Requires ``CONFIG_RTE_LIBRTE_IEEE1588=y``.