diff mbox series

test: fix build

Message ID 20181106143501.6515-1-ferruh.yigit@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series test: fix build | expand

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK

Commit Message

Ferruh Yigit Nov. 6, 2018, 2:35 p.m. UTC
With "make -C test/" command getting following warnings:
 awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
      for reading (No such file or directory)
 awk: cmd. line:1: fatal: cannot open file
      `/test-pipeline/test-pipeline/' for reading (No such file or
      directory)
 awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
      for reading (No such file or directory)

This is because unexpected/invalid MAPFILE param passed to
check-experimental-syms.sh

There is no easy way to unify MAPFILE for different build options,
instead add an input verification to script, and silently ignore wrong
values.

Fixes: a6ec31597a0b ("mk: add experimental tag check")
Cc: stable@dpdk.org

Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
---
Cc: nhorman@tuxdriver.com
---
 buildtools/check-experimental-syms.sh | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Neil Horman Nov. 6, 2018, 7:54 p.m. UTC | #1
On Tue, Nov 06, 2018 at 02:35:01PM +0000, Ferruh Yigit wrote:
> With "make -C test/" command getting following warnings:
>  awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
>       for reading (No such file or directory)
>  awk: cmd. line:1: fatal: cannot open file
>       `/test-pipeline/test-pipeline/' for reading (No such file or
>       directory)
>  awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
>       for reading (No such file or directory)
> 
> This is because unexpected/invalid MAPFILE param passed to
> check-experimental-syms.sh
> 
> There is no easy way to unify MAPFILE for different build options,
> instead add an input verification to script, and silently ignore wrong
> values.
> 
> Fixes: a6ec31597a0b ("mk: add experimental tag check")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> ---
> Cc: nhorman@tuxdriver.com
> ---
>  buildtools/check-experimental-syms.sh | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
> index d0915102d..7d1f3a568 100755
> --- a/buildtools/check-experimental-syms.sh
> +++ b/buildtools/check-experimental-syms.sh
> @@ -5,6 +5,12 @@
>  MAPFILE=$1
>  OBJFILE=$2
>  
> +# added check for "make -C test/" usage
> +if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
> +then
> +	exit 0
> +fi
> +
>  if [ -d $MAPFILE ]
>  then
>  	exit 0
> -- 
> 2.17.2
> 
> 
Acked-by: Neil Horman <nhorman@tuxdriver.com>
Thomas Monjalon Nov. 12, 2018, 12:39 a.m. UTC | #2
06/11/2018 20:54, Neil Horman:
> On Tue, Nov 06, 2018 at 02:35:01PM +0000, Ferruh Yigit wrote:
> > With "make -C test/" command getting following warnings:
> >  awk: cmd. line:1: fatal: cannot open file `/cmdline_test/cmdline_test/'
> >       for reading (No such file or directory)
> >  awk: cmd. line:1: fatal: cannot open file
> >       `/test-pipeline/test-pipeline/' for reading (No such file or
> >       directory)
> >  awk: cmd. line:1: fatal: cannot open file `/test-acl/test-acl/'
> >       for reading (No such file or directory)
> > 
> > This is because unexpected/invalid MAPFILE param passed to
> > check-experimental-syms.sh
> > 
> > There is no easy way to unify MAPFILE for different build options,
> > instead add an input verification to script, and silently ignore wrong
> > values.
> > 
> > Fixes: a6ec31597a0b ("mk: add experimental tag check")
> > Cc: stable@dpdk.org
> > 
> > Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Acked-by: Neil Horman <nhorman@tuxdriver.com>

Applied, thanks
diff mbox series

Patch

diff --git a/buildtools/check-experimental-syms.sh b/buildtools/check-experimental-syms.sh
index d0915102d..7d1f3a568 100755
--- a/buildtools/check-experimental-syms.sh
+++ b/buildtools/check-experimental-syms.sh
@@ -5,6 +5,12 @@ 
 MAPFILE=$1
 OBJFILE=$2
 
+# added check for "make -C test/" usage
+if [ ! -e $MAPFILE ] || [ ! -f $OBJFILE ]
+then
+	exit 0
+fi
+
 if [ -d $MAPFILE ]
 then
 	exit 0