[v5,1/3] net/failsafe: remove D_XOPEN_SOURCE flag
Checks
Commit Message
Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to
build when changing some DPDK libraries. The flag is not needed
and therefore is removed.
Signed-off-by: Cody Doucette <doucette@bu.edu>
---
drivers/net/failsafe/Makefile | 1 -
drivers/net/failsafe/meson.build | 1 -
2 files changed, 2 deletions(-)
Comments
31/10/2018 03:17, Cody Doucette:
> Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to
> build when changing some DPDK libraries. The flag is not needed
> and therefore is removed.
>
> Signed-off-by: Cody Doucette <doucette@bu.edu>
Gaetan, please approve that the flag is not needed.
On Wed, Oct 31, 2018 at 06:02:29PM +0100, Thomas Monjalon wrote:
> 31/10/2018 03:17, Cody Doucette:
> > Compilation flag D_XOPEN_SOURCE is causing failsafe to fail to
> > build when changing some DPDK libraries. The flag is not needed
> > and therefore is removed.
> >
> > Signed-off-by: Cody Doucette <doucette@bu.edu>
>
> Gaetan, please approve that the flag is not needed.
>
I suspected popen or fgets from failsafe_args.c, but I wasn't able
to find a reason for the define. I can't remember the initial reason for
it, sorry.
I have tested the build on linux and freebsd, without issue, so at this
point I think this is ok.
@@ -34,7 +34,6 @@ CFLAGS += -std=gnu99 -Wextra
CFLAGS += -O3
CFLAGS += -I.
CFLAGS += -D_DEFAULT_SOURCE
-CFLAGS += -D_XOPEN_SOURCE=700
CFLAGS += $(WERROR_FLAGS)
CFLAGS += -Wno-strict-prototypes
CFLAGS += -pedantic
@@ -3,7 +3,6 @@
cflags += '-std=gnu99'
cflags += '-D_DEFAULT_SOURCE'
-cflags += '-D_XOPEN_SOURCE=700'
cflags += '-pedantic'
if host_machine.system() == 'linux'
cflags += '-DLINUX'