diff mbox series

[v1,1/9] app/procinfo: add usage for new debug

Message ID 20181023135751.21536-1-vipin.varghese@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series [v1,1/9] app/procinfo: add usage for new debug |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail Compilation issues

Commit Message

Varghese, Vipin Oct. 23, 2018, 1:57 p.m. UTC 
  Update the file with MACRO for stats border, usage text information
and string comparision.

Signed-off-by: Vipin Varghese <vipin.varghese@intel.com>
---
 app/proc-info/main.c | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

Comments

Stephen Hemminger Oct. 23, 2018, 3:19 p.m. UTC | #1 
On Tue, 23 Oct 2018 19:27:43 +0530
Vipin Varghese <vipin.varghese@intel.com> wrote:

> +		"  --dbg-port to display information for all available ports\n"
> +		"  --dbg-tm to display information for traffic manager\n"
> +		"  --dbg-crypto to display information for crypto\n"
> +		"  --dbg-ring[=name] to display information for ring\n"
> +		"  --dbg-mempool[=name] to display information for mempool\n",

These might be useful outside of debugging, why not give them names like
  --dbg-port == --show-port
  --dpb-tm   == --show-tm 

etc.
Varghese, Vipin Oct. 24, 2018, 5:41 a.m. UTC | #2 
Hi Stephen,

<snipped>

> 
> > +		"  --dbg-port to display information for all available ports\n"
> > +		"  --dbg-tm to display information for traffic manager\n"
> > +		"  --dbg-crypto to display information for crypto\n"
> > +		"  --dbg-ring[=name] to display information for ring\n"
> > +		"  --dbg-mempool[=name] to display information for
> mempool\n",
> 
> These might be useful outside of debugging, why not give them names like
>   --dbg-port == --show-port
>   --dpb-tm   == --show-tm
> 
 
Ok, as I understand you would like to reword 'dbg' to 'show' for 'port|tm|crypto|ring|mempool'. Sure I will do the same and share v2

Thanks
Vipin Varghese
Stephen Hemminger Oct. 24, 2018, 3:56 p.m. UTC | #3 
On Wed, 24 Oct 2018 05:41:32 +0000
"Varghese, Vipin" <vipin.varghese@intel.com> wrote:

> Hi Stephen,
> 
> <snipped>
> 
> >   
> > > +		"  --dbg-port to display information for all available ports\n"
> > > +		"  --dbg-tm to display information for traffic manager\n"
> > > +		"  --dbg-crypto to display information for crypto\n"
> > > +		"  --dbg-ring[=name] to display information for ring\n"
> > > +		"  --dbg-mempool[=name] to display information for  
> > mempool\n",
> > 
> > These might be useful outside of debugging, why not give them names like
> >   --dbg-port == --show-port
> >   --dpb-tm   == --show-tm
> >   
>  
> Ok, as I understand you would like to reword 'dbg' to 'show' for 'port|tm|crypto|ring|mempool'. Sure I will do the same and share v2
> 
> Thanks
> Vipin Varghese
> 

Yes. sorry if I wasn't clear enough.
diff mbox series

Patch

diff --git a/app/proc-info/main.c b/app/proc-info/main.c
index c20effa4f..92854f5ba 100644
--- a/app/proc-info/main.c
+++ b/app/proc-info/main.c
@@ -36,6 +36,10 @@ 
 
 #define MAX_STRING_LEN 256
 
+#define STATS_BDR_FMT "========================================"
+#define STATS_BDR_STR(w, s) printf("%.*s%s%.*s\n", w, \
+	STATS_BDR_FMT, s, w, STATS_BDR_FMT)
+
 /**< mask of enabled ports */
 static uint32_t enabled_port_mask;
 /**< Enable stats. */
@@ -83,7 +87,12 @@  proc_info_usage(const char *prgname)
 		"  --stats-reset: to reset port statistics\n"
 		"  --xstats-reset: to reset port extended statistics\n"
 		"  --collectd-format: to print statistics to STDOUT in expected by collectd format\n"
-		"  --host-id STRING: host id used to identify the system process is running on\n",
+		"  --host-id STRING: host id used to identify the system process is running on\n"
+		"  --dbg-port to display information for all available ports\n"
+		"  --dbg-tm to display information for traffic manager\n"
+		"  --dbg-crypto to display information for crypto\n"
+		"  --dbg-ring[=name] to display information for ring\n"
+		"  --dbg-mempool[=name] to display information for mempool\n",
 		prgname);
 }
 
@@ -190,6 +199,11 @@  proc_info_parse_args(int argc, char **argv)
 		{"collectd-format", 0, NULL, 0},
 		{"xstats-ids", 1, NULL, 1},
 		{"host-id", 0, NULL, 0},
+		{"dbg-port", 0, NULL, 0},
+		{"dbg-tm", 0, NULL, 0},
+		{"dbg-crypto", 0, NULL, 0},
+		{"dbg-ring", optional_argument, NULL, 0},
+		{"dbg-mempool", optional_argument, NULL, 0},
 		{NULL, 0, 0, 0}
 	};